Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chart): revert env OPENEBS_NAMESPACE to LVM_NAMESPACE for v1.6.x #333

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

niladrih
Copy link
Member

The env LVM_NAMESPACE was changed to OPENEBS_NAMESPACE on the develop branch as a part of #324. This change breaks v1.6.x.

Need to investigate if it breaks develop as well.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.95%. Comparing base (8feeaa0) to head (29cdf45).
Report is 27 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #333      +/-   ##
===========================================
- Coverage    98.66%   97.95%   -0.71%     
===========================================
  Files            2        2              
  Lines          673      784     +111     
===========================================
+ Hits           664      768     +104     
- Misses           5        9       +4     
- Partials         4        7       +3     
Flag Coverage Δ
bddtests 97.95% <ø> (-0.71%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@niladrih niladrih merged commit 45e0fbd into openebs:develop Sep 19, 2024
5 checks passed
@niladrih niladrih deleted the chart-env-fix branch September 19, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants