refactor(plugin): expand scope of ExecuteOperations trait #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niladrih
requested review from
tiagolobocastro,
Abhinandan-Purkait,
abhilashshetty04 and
dsharma-dc
The Trait ExecuteOptions requires a specific type from the this repo to work. This poses as a limitation for repos which use this codebase as a git module. This change adheres to the patterns where a clap::Parser struct instance is passed to the function, while removing dependency on the exact type of clap::Parser. Also, adds an output argument to support the existing users of this trait who depend on the CliArgs.output member from the cli_args arg. Signed-off-by: Niladri Halder <[email protected]>
niladrih
force-pushed
the
execute_operations
branch
from
2bf455a to
589c51b
Compare
|
This PR is not required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Trait ExecuteOptions requires a specific type from the this repo to work. This poses as a limitation for repos which use this codebase as a git module. This change adheres to the patterns where a clap::Parser struct instance is passed to the function, while removing dependency on the exact type of clap::Parser. Also, adds an output argument to support the existing users of this trait who depend on the CliArgs.output member from the cli_args arg.