Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Volume Health Information #946

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Conversation

tiagolobocastro
Copy link
Contributor

fix(rest-plugin): show missing target if missing

If the target is meant to be there, but it's missing, state that.

feat(rest-plugin): add clean shutdown to volume output

feat(rest-plugin): add replica topology health info

feat(rest): add health information

Enhance the volume with pstor health information which is retried from
etcd using watches.

feat(core/watcher): add pstor watcher for volume health info

Add a volume health watcher which caches updates from etcd for every volume.
When etcd entry is deleted, the equivalent entry in the cache is also deleted.

When volume is republished sucessfully, the older target health information are
also removed from the cache.

fix: remove volume health entries on delete

When a volume is deleted, destroy all related health entries.
It has been observed that upon republished, the previous info
is not deleted, so even if we fix that a lot of entries may
already be leaked, so let's ensure we delete all entries for
a given volume on volume deletion.

refactor(pstor/watcher): add missing value on watch callback

When a volume is deleted, destroy all related health entries.
It has been observed that upon republished, the previous info
is not deleted, so even if we fix that a lot of entries may
already be leaked, so let's ensure we delete all entries for
a given volume on volume deletion.

Signed-off-by: Tiago Castro <[email protected]>
Add a volume health watcher which caches updates from etcd for every volume.
When etcd entry is deleted, the equivalent entry in the cache is also deleted.

When volume is republished sucessfully, the older target health information are
also removed from the cache.

Signed-off-by: Tiago Castro <[email protected]>
@tiagolobocastro tiagolobocastro requested a review from a team as a code owner March 11, 2025 20:06
Enhance the volume with pstor health information which is retried from
etcd using watches.

Signed-off-by: Tiago Castro <[email protected]>
If the target is meant to be there, but it's missing, state that.

Signed-off-by: Tiago Castro <[email protected]>
Checks the volume health as replicas are faulted, rebuilt and
targets shutdown cleanly or otherwise.

Signed-off-by: Tiago Castro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant