-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add overview and migrate existing to github #1805
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tiagolobocastro
commented
Jan 22, 2025
•
edited
Loading
edited
tiagolobocastro
requested review from
sinhaashish,
Abhinandan-Purkait,
niladrih,
abhilashshetty04 and
dsharma-dc
January 22, 2025 20:02
tiagolobocastro
commented
Jan 22, 2025
tiagolobocastro
changed the title
docs: add overview for arch and improve csi
docs: add overview and migrate existing to github
Jan 23, 2025
This was referenced Jan 23, 2025
tiagolobocastro
force-pushed
the
docs
branch
8 times, most recently
from
January 24, 2025 23:49
01d75c2
to
d33e3fa
Compare
dsharma-dc
reviewed
Jan 27, 2025
sinhaashish
reviewed
Jan 27, 2025
Parse a size with unit post-fix for the malloc and null bdevs. This makes it much easier to use, example: size=1TiB vs size_mb=1048576 Signed-off-by: Tiago Castro <[email protected]>
Adds an overview png for the README Improves slight CSI wording and adds a CSI diagram Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
force-pushed
the
docs
branch
4 times, most recently
from
January 27, 2025 13:31
0e06a13
to
8dd7d67
Compare
tiagolobocastro
force-pushed
the
docs
branch
8 times, most recently
from
January 27, 2025 13:50
77a7e88
to
bf7169a
Compare
Could not get the images to display within the mermaid graph sadly :( |
sinhaashish
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one last comment otherwise lgtm
dsharma-dc
approved these changes
Jan 28, 2025
Signed-off-by: Tiago Castro <[email protected]>
bors merge |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.