feat(snapshot): get lba from snapshot which is ancestor of current blob #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrudaya21
requested review from
dsavitskiy,
tiagolobocastro and
dsharma-dc
and removed request for
dsavitskiy,
tiagolobocastro and
dsharma-dc
hrudaya21
force-pushed
the
check_cluster_alloc_from_blob_ancestor
branch
4 times, most recently
from
28320f7 to
cde82b3
Compare
hrudaya21
force-pushed
the
check_cluster_alloc_from_blob_ancestor
branch
2 times, most recently
from
5deefa4 to
f538378
Compare
hrudaya21
force-pushed
the
check_cluster_alloc_from_blob_ancestor
branch
2 times, most recently
from
7437796 to
be46585
Compare
hrudaya21
force-pushed
the
check_cluster_alloc_from_blob_ancestor
branch
from
be46585 to
f04a5f6
Compare
tiagolobocastro
approved these changes
Jan 3, 2024
dsharma-dc
reviewed
Jan 4, 2024
hrudaya21
force-pushed
the
check_cluster_alloc_from_blob_ancestor
branch
from
f04a5f6 to
05ab36e
Compare
dsharma-dc
approved these changes
Jan 5, 2024
hrudaya21
force-pushed
the
check_cluster_alloc_from_blob_ancestor
branch
from
05ab36e to
fef3a8a
Compare
Signed-off-by: Hrudaya <[email protected]>
hrudaya21
force-pushed
the
check_cluster_alloc_from_blob_ancestor
branch
from
fef3a8a to
ab9f764
Compare
tiagolobocastro
pushed a commit
that referenced
this pull request
Apr 22, 2024
…ob (#38) Signed-off-by: Hrudaya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when data is copied form the healthy replica to build a new replica, it only takes allocated blocks from current replica. It doesn't consider the snapshot data of the healthy replica. Due to copy on write, snapshot owns some data of the helathy replica which doesn't get copied to the new replica.
With this fix, while reading lba for the replica, it consider all the snapshots associated with the replica to get the data and copied to the newly created replica.