Skip to content
This repository has been archived by the owner on Aug 1, 2024. It is now read-only.

Commit

Permalink
fix: Use correct name for --detach param (#1140)
Browse files Browse the repository at this point in the history
`-d` is valid and so is `--detach`. But the `--d` that was used here (with
two hyphens) only worked on some machines. I believe that was autocorrected
to `--detach` on those machines because it was a unique prefix, as I was
also able to use `--det`.

This might be a matter of versions, or of `docker-compose` vs.
`docker compose` shims, or just difference by OS. But in any case we should
use a documented version of the flag.
  • Loading branch information
timmc-edx committed Aug 1, 2023
1 parent e768331 commit e931768
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ dev.up.with-watchers.%: ## Bring up services and their dependencies + asset watc
dev.up.without-deps: _expects-service-list.dev.up.without-deps

impl-dev.up.without-deps.%: dev.check-memory ## Bring up services by themselves.
docker-compose up --d --no-deps $$(echo $* | tr + " ")
docker-compose up -d --no-deps $$(echo $* | tr + " ")

dev.up.without-deps.%: ## Bring up services by themselves.
@scripts/send_metrics.py wrap "dev.up.without-deps.$*"
Expand Down

0 comments on commit e931768

Please sign in to comment.