This repository has been archived by the owner on Aug 1, 2024. It is now read-only.
feat: Remove redundant seed_permissions_roles call for demo course
#1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `import` management command (from cms contentstore) is called right before the `seed_permissions_roles` command (from lms discussions). However, the import command already performs the seeding. See #1129 for archaeological notes. Confirmation that the call doesn't add anything: - Provisioned LMS with `DEVSTACK_SKIP_DEMO=true` - Manually ran first two commands for importing demo course (git clone, `import` management command) - Took MySQL DB dumps - Ran final demo course command, `seed_permissions_roles` - Took new DB dumps - Diff of SQL files showed only a change in the dump dates
nsprenkle
pushed a commit
that referenced
this pull request
Nov 21, 2023
…1142) The `import` management command (from cms contentstore) is called right before the `seed_permissions_roles` command (from lms discussions). However, the import command already performs the seeding. See #1129 for archaeological notes. Confirmation that the call doesn't add anything: - Provisioned LMS with `DEVSTACK_SKIP_DEMO=true` - Manually ran first two commands for importing demo course (git clone, `import` management command) - Took MySQL DB dumps - Ran final demo course command, `seed_permissions_roles` - Took new DB dumps - Diff of SQL files showed only a change in the dump dates
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
importmanagement command (from cms contentstore) is called right before theseed_permissions_rolescommand (from lms discussions). However, the import command already performs the seeding.See #1129 for archaeological notes.
Confirmation that the call doesn't add anything:
DEVSTACK_SKIP_DEMO=trueimportmanagement command)seed_permissions_rolesI've completed each of the following or determined they are not applicable: