refactor: address review feedback

openedx-unsupported · Aug 18, 2023 · 09dac90 · 09dac90
1 parent 6aef912
commit 09dac90
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/Source/DiscoveryWebViewHelper.swift b/Source/DiscoveryWebViewHelper.swift
@@ -96,7 +96,7 @@ class DiscoveryWebViewHelper: NSObject {
             }
         }
 
-        let offSet = container.view.viewWithTag(FakeStatusBarViewTag)?.frame.size.height ?? 0
+        let offSet = container.view.viewWithTag(statuBarViewTag)?.frame.size.height ?? 0
         titleView.snp.remakeConstraints { make in
             make.top.equalTo(contentView).offset(offSet)
             make.trailing.equalTo(contentView)

diff --git a/Source/NewCourseDashboardViewController.swift b/Source/NewCourseDashboardViewController.swift
@@ -8,7 +8,8 @@
 
 import UIKit
 
-let FakeStatusBarViewTag: Int = 123454321
+// view used at the exact same location of status bar in case of hidden navbar
+let statuBarViewTag: Int = 123454321
 
 public protocol NewCourseDashboardViewControllerDelegate: AnyObject {
     func showCourseDates(bannerInfo: DatesBannerInfo?, delegate: CourseOutlineTableController?)
@@ -604,17 +605,17 @@ public extension UIViewController {
     func setStatusBar(inside contentView: UIView? = nil, color: UIColor) {
         let overView: UIView
 
-        if let contentView = contentView, let taggedView = contentView.viewWithTag(FakeStatusBarViewTag) {
+        if let contentView = contentView, let taggedView = contentView.viewWithTag(statuBarViewTag) {
             overView = taggedView
         } else if contentView != nil {
             overView = UIView()
-            overView.tag = FakeStatusBarViewTag
+            overView.tag = statuBarViewTag
             contentView?.addSubview(overView)
-        } else if let taggedView = view.viewWithTag(FakeStatusBarViewTag) {
+        } else if let taggedView = view.viewWithTag(statuBarViewTag) {
             overView = taggedView
         } else {
             overView = UIView()
-            overView.tag = FakeStatusBarViewTag
+            overView.tag = statuBarViewTag
             view.addSubview(overView)
         }