chore: remove code in the code base around discover hardcoded path

openedx-unsupported · Aug 25, 2023 · 460e0c6 · 460e0c6
1 parent 6771e76
commit 460e0c6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/Source/OEXFindCoursesViewController.m b/Source/OEXFindCoursesViewController.m
@@ -20,7 +20,6 @@
 
 static NSString* const OEXFindCoursesCourseInfoPath = @"course_info/";
 static NSString* const OEXFindCoursesPathIDKey = @"path_id";
-static NSString* const OEXFindCoursePathPrefix = @"course/";
 
 @interface OEXFindCoursesViewController () <WebViewNavigationDelegate, InterfaceOrientationOverriding>
 
@@ -100,10 +99,7 @@ - (DiscoveryConfig*)discoveryConfig {
 
 - (NSString*)getCoursePathIDFromURL:(NSURL*)url {
     if([url.scheme isEqualToString:OEXFindCoursesLinkURLScheme] && [url.oex_hostlessPath isEqualToString:OEXFindCoursesCourseInfoPath]) {
-        NSString* path = url.oex_queryParameters[OEXFindCoursesPathIDKey];
-        // the site sends us things of the form "course/<path_id>" we only want the path id
-        NSString* pathID = [path stringByReplacingOccurrencesOfString:OEXFindCoursePathPrefix withString:@"" options:0 range:NSMakeRange(0, OEXFindCoursePathPrefix.length)];
-        return pathID;
+        return url.oex_queryParameters[OEXFindCoursesPathIDKey];
     }
     return nil;
 }

diff --git a/Source/WebView/DiscoveryHelper.swift b/Source/WebView/DiscoveryHelper.swift
@@ -12,7 +12,6 @@ import UIKit
 enum URIString: String {
     case appURLScheme = "edxapp"
     case pathPlaceHolder = "{path_id}"
-    case coursePathPrefix = "course/"
 }
 
 fileprivate enum URLParameterKeys: String, RawStringExtractable {
@@ -47,8 +46,7 @@ enum WebviewActions: String {
             return nil
         }
 
-        // the site sends us things of the form "course/<path_id>" we only want the path id
-        return path.replacingOccurrences(of: URIString.coursePathPrefix.rawValue, with: "")
+        return path
     }
 
     class func parse(url: URL) -> (courseId: String?, emailOptIn: Bool)? {