fix: Fix webkit crash in course discovery (#1658)

openedx-unsupported · Jul 26, 2022 · 7b867ac · 7b867ac
1 parent 8a1cace
commit 7b867ac
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/Source/DiscoveryWebViewHelper.swift b/Source/DiscoveryWebViewHelper.swift
@@ -200,7 +200,10 @@ extension DiscoveryWebViewHelper: WKNavigationDelegate {
             let capturedLink = navigationAction.navigationType == .linkActivated
             let outsideLink = (request.mainDocumentURL?.host != self.request?.url?.host)
             if let url = request.url, outsideLink || capturedLink {
-                guard let contrller = delegate?.webViewContainingController(), UIApplication.shared.canOpenURL(url) else { return }
+                guard let contrller = delegate?.webViewContainingController(), UIApplication.shared.canOpenURL(url) else {
+                    decisionHandler(.cancel)
+                    return
+                }
                 environment.analytics.trackEvent(with: .DiscoverExternalLinkOpenAlert, name: .DiscoverExternalLinkOpenAlert, category: .Discovery, info: ["url" : url.absoluteString])
                 let alertController = UIAlertController().showAlert(withTitle: Strings.leavingAppTitle, message: Strings.leavingAppMessage(platformName: environment.config.platformName()), cancelButtonTitle: nil, onViewController: contrller) { _, _, _ in }