Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

Commit

Permalink
chore: profile options screen improvements (#1724)
Browse files Browse the repository at this point in the history
  • Loading branch information
@saeedbashir
saeedbashir committed Mar 20, 2023
1 parent 3cbda77 commit ac8e1d9
Show file tree
Hide file tree
Showing 12 changed files with 37 additions and 37 deletions.
8 changes: 4 additions & 4 deletions Source/ProfileOptionsViewController.swift
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1018,7 +1018,7 @@ class PrivacyCell: UITableViewCell {

private lazy var optionLabel: UILabel = {
let label = UILabel()
label.attributedText = titleTextStyle.attributedString(withText: Strings.ProfileOptions.Purchases.title)
label.attributedText = titleTextStyle.attributedString(withText: Strings.ProfileOptions.Privacy.title)
label.accessibilityIdentifier = "PrivacyCell:option-label"
return label
}()
Expand Down Expand Up @@ -1136,8 +1136,7 @@ class HelpCell: UITableViewCell {

private var platformName: String? {
didSet {
guard let platformName = platformName else { return }
feedbackSubtitleLabel.attributedText = textStyle.attributedString(withText: Strings.ProfileOptions.Help.Message.support(platformName: platformName)).setLineSpacing(lineSpacing)
feedbackSubtitleLabel.attributedText = textStyle.attributedString(withText: Strings.ProfileOptions.Help.Message.feedback)
}
}

Expand Down Expand Up @@ -1199,7 +1198,8 @@ class HelpCell: UITableViewCell {
private lazy var supportSubtitleLabel: UILabel = {
let label = UILabel()
label.numberOfLines = 0
label.attributedText = textStyle.attributedString(withText: Strings.ProfileOptions.Help.Message.feedback).setLineSpacing(lineSpacing)
label.attributedText = textStyle.attributedString(withText:
Strings.ProfileOptions.Help.Message.support(platformName: platformName ?? "")).setLineSpacing(lineSpacing)
label.accessibilityIdentifier = "HelpCell:support-subtitle-label"
return label
}()
Expand Down
6 changes: 3 additions & 3 deletions Source/ar.lproj/ProfileOptions.strings
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@
/* Settings title for privacy */
"PROFILE_OPTIONS.PRIVACY.TITLE" = "Privacy";
/* Settings title for privacy */
"PROFILE_OPTIONS.PRIVACY.PRIVACY_POLICY" = "Privacy policy";
"PROFILE_OPTIONS.PRIVACY.PRIVACY_POLICY" = "Privacy Policy";
/* Settings title for privacy cookie policy*/
"PROFILE_OPTIONS.PRIVACY.COOKIE_POLICY" = "Cookie policy";
"PROFILE_OPTIONS.PRIVACY.COOKIE_POLICY" = "Cookie Policy";
/* Settings title for privacy do not sell my personal data*/
"PROFILE_OPTIONS.PRIVACY.DATA_SELL_CONSENT" = "Do not sell my personal data";
"PROFILE_OPTIONS.PRIVACY.DATA_SELL_CONSENT" = "Do Not Sell My Personal Information";
6 changes: 3 additions & 3 deletions Source/de.lproj/ProfileOptions.strings
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@
/* Settings title for privacy */
"PROFILE_OPTIONS.PRIVACY.TITLE" = "Privacy";
/* Settings title for privacy */
"PROFILE_OPTIONS.PRIVACY.PRIVACY_POLICY" = "Privacy policy";
"PROFILE_OPTIONS.PRIVACY.PRIVACY_POLICY" = "Privacy Policy";
/* Settings title for privacy cookie policy*/
"PROFILE_OPTIONS.PRIVACY.COOKIE_POLICY" = "Cookie policy";
"PROFILE_OPTIONS.PRIVACY.COOKIE_POLICY" = "Cookie Policy";
/* Settings title for privacy do not sell my personal data*/
"PROFILE_OPTIONS.PRIVACY.DATA_SELL_CONSENT" = "Do not sell my personal data";
"PROFILE_OPTIONS.PRIVACY.DATA_SELL_CONSENT" = "Do Not Sell My Personal Information";
6 changes: 3 additions & 3 deletions Source/en.lproj/ProfileOptions.strings
View file
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@
/* Settings title for privacy */
"PROFILE_OPTIONS.PRIVACY.TITLE" = "Privacy";
/* Settings title for privacy */
"PROFILE_OPTIONS.PRIVACY.PRIVACY_POLICY" = "Privacy policy";
"PROFILE_OPTIONS.PRIVACY.PRIVACY_POLICY" = "Privacy Policy";
/* Settings title for privacy cookie policy*/
"PROFILE_OPTIONS.PRIVACY.COOKIE_POLICY" = "Cookie policy";
"PROFILE_OPTIONS.PRIVACY.COOKIE_POLICY" = "Cookie Policy";
/* Settings title for privacy do not sell my personal data*/
"PROFILE_OPTIONS.PRIVACY.DATA_SELL_CONSENT" = "Do not sell my personal data";
"PROFILE_OPTIONS.PRIVACY.DATA_SELL_CONSENT" = "Do Not Sell My Personal Information";
6 changes: 3 additions & 3 deletions Source/es-419.lproj/ProfileOptions.strings
View file
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@
/* Settings title for privacy */
"PROFILE_OPTIONS.PRIVACY.TITLE" = "Privacy";
/* Settings title for privacy */
"PROFILE_OPTIONS.PRIVACY.PRIVACY_POLICY" = "Privacy policy";
"PROFILE_OPTIONS.PRIVACY.PRIVACY_POLICY" = "Privacy Policy";
/* Settings title for privacy cookie policy*/
"PROFILE_OPTIONS.PRIVACY.COOKIE_POLICY" = "Cookie policy";
"PROFILE_OPTIONS.PRIVACY.COOKIE_POLICY" = "Cookie Policy";
/* Settings title for privacy do not sell my personal data*/
"PROFILE_OPTIONS.PRIVACY.DATA_SELL_CONSENT" = "Do not sell my personal data";
"PROFILE_OPTIONS.PRIVACY.DATA_SELL_CONSENT" = "Do Not Sell My Personal Information";
6 changes: 3 additions & 3 deletions Source/fr.lproj/ProfileOptions.strings
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@
/* Settings title for privacy */
"PROFILE_OPTIONS.PRIVACY.TITLE" = "Privacy";
/* Settings title for privacy */
"PROFILE_OPTIONS.PRIVACY.PRIVACY_POLICY" = "Privacy policy";
"PROFILE_OPTIONS.PRIVACY.PRIVACY_POLICY" = "Privacy Policy";
/* Settings title for privacy cookie policy*/
"PROFILE_OPTIONS.PRIVACY.COOKIE_POLICY" = "Cookie policy";
"PROFILE_OPTIONS.PRIVACY.COOKIE_POLICY" = "Cookie Policy";
/* Settings title for privacy do not sell my personal data*/
"PROFILE_OPTIONS.PRIVACY.DATA_SELL_CONSENT" = "Do not sell my personal data";
"PROFILE_OPTIONS.PRIVACY.DATA_SELL_CONSENT" = "Do Not Sell My Personal Information";
6 changes: 3 additions & 3 deletions Source/he.lproj/ProfileOptions.strings
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@
/* Settings title for privacy */
"PROFILE_OPTIONS.PRIVACY.TITLE" = "Privacy";
/* Settings title for privacy */
"PROFILE_OPTIONS.PRIVACY.PRIVACY_POLICY" = "Privacy policy";
"PROFILE_OPTIONS.PRIVACY.PRIVACY_POLICY" = "Privacy Policy";
/* Settings title for privacy cookie policy*/
"PROFILE_OPTIONS.PRIVACY.COOKIE_POLICY" = "Cookie policy";
"PROFILE_OPTIONS.PRIVACY.COOKIE_POLICY" = "Cookie Policy";
/* Settings title for privacy do not sell my personal data*/
"PROFILE_OPTIONS.PRIVACY.DATA_SELL_CONSENT" = "Do not sell my personal data";
"PROFILE_OPTIONS.PRIVACY.DATA_SELL_CONSENT" = "Do Not Sell My Personal Information";
6 changes: 3 additions & 3 deletions Source/ja.lproj/ProfileOptions.strings
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@
/* Settings title for privacy */
"PROFILE_OPTIONS.PRIVACY.TITLE" = "Privacy";
/* Settings title for privacy */
"PROFILE_OPTIONS.PRIVACY.PRIVACY_POLICY" = "Privacy policy";
"PROFILE_OPTIONS.PRIVACY.PRIVACY_POLICY" = "Privacy Policy";
/* Settings title for privacy cookie policy*/
"PROFILE_OPTIONS.PRIVACY.COOKIE_POLICY" = "Cookie policy";
"PROFILE_OPTIONS.PRIVACY.COOKIE_POLICY" = "Cookie Policy";
/* Settings title for privacy do not sell my personal data*/
"PROFILE_OPTIONS.PRIVACY.DATA_SELL_CONSENT" = "Do not sell my personal data";
"PROFILE_OPTIONS.PRIVACY.DATA_SELL_CONSENT" = "Do Not Sell My Personal Information";
6 changes: 3 additions & 3 deletions Source/pt-BR.lproj/ProfileOptions.strings
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@
/* Settings title for privacy */
"PROFILE_OPTIONS.PRIVACY.TITLE" = "Privacy";
/* Settings title for privacy */
"PROFILE_OPTIONS.PRIVACY.PRIVACY_POLICY" = "Privacy policy";
"PROFILE_OPTIONS.PRIVACY.PRIVACY_POLICY" = "Privacy Policy";
/* Settings title for privacy cookie policy*/
"PROFILE_OPTIONS.PRIVACY.COOKIE_POLICY" = "Cookie policy";
"PROFILE_OPTIONS.PRIVACY.COOKIE_POLICY" = "Cookie Policy";
/* Settings title for privacy do not sell my personal data*/
"PROFILE_OPTIONS.PRIVACY.DATA_SELL_CONSENT" = "Do not sell my personal data";
"PROFILE_OPTIONS.PRIVACY.DATA_SELL_CONSENT" = "Do Not Sell My Personal Information";
6 changes: 3 additions & 3 deletions Source/tr.lproj/ProfileOptions.strings
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@
/* Settings title for privacy */
"PROFILE_OPTIONS.PRIVACY.TITLE" = "Privacy";
/* Settings title for privacy */
"PROFILE_OPTIONS.PRIVACY.PRIVACY_POLICY" = "Privacy policy";
"PROFILE_OPTIONS.PRIVACY.PRIVACY_POLICY" = "Privacy Policy";
/* Settings title for privacy cookie policy*/
"PROFILE_OPTIONS.PRIVACY.COOKIE_POLICY" = "Cookie policy";
"PROFILE_OPTIONS.PRIVACY.COOKIE_POLICY" = "Cookie Policy";
/* Settings title for privacy do not sell my personal data*/
"PROFILE_OPTIONS.PRIVACY.DATA_SELL_CONSENT" = "Do not sell my personal data";
"PROFILE_OPTIONS.PRIVACY.DATA_SELL_CONSENT" = "Do Not Sell My Personal Information";
6 changes: 3 additions & 3 deletions Source/vi.lproj/ProfileOptions.strings
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@
/* Settings title for privacy */
"PROFILE_OPTIONS.PRIVACY.TITLE" = "Privacy";
/* Settings title for privacy */
"PROFILE_OPTIONS.PRIVACY.PRIVACY_POLICY" = "Privacy policy";
"PROFILE_OPTIONS.PRIVACY.PRIVACY_POLICY" = "Privacy Policy";
/* Settings title for privacy cookie policy*/
"PROFILE_OPTIONS.PRIVACY.COOKIE_POLICY" = "Cookie policy";
"PROFILE_OPTIONS.PRIVACY.COOKIE_POLICY" = "Cookie Policy";
/* Settings title for privacy do not sell my personal data*/
"PROFILE_OPTIONS.PRIVACY.DATA_SELL_CONSENT" = "Do not sell my personal data";
"PROFILE_OPTIONS.PRIVACY.DATA_SELL_CONSENT" = "Do Not Sell My Personal Information";
6 changes: 3 additions & 3 deletions Source/zh-Hans.lproj/ProfileOptions.strings
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@
/* Settings title for privacy */
"PROFILE_OPTIONS.PRIVACY.TITLE" = "Privacy";
/* Settings title for privacy */
"PROFILE_OPTIONS.PRIVACY.PRIVACY_POLICY" = "Privacy policy";
"PROFILE_OPTIONS.PRIVACY.PRIVACY_POLICY" = "Privacy Policy";
/* Settings title for privacy cookie policy*/
"PROFILE_OPTIONS.PRIVACY.COOKIE_POLICY" = "Cookie policy";
"PROFILE_OPTIONS.PRIVACY.COOKIE_POLICY" = "Cookie Policy";
/* Settings title for privacy do not sell my personal data*/
"PROFILE_OPTIONS.PRIVACY.DATA_SELL_CONSENT" = "Do not sell my personal data";
"PROFILE_OPTIONS.PRIVACY.DATA_SELL_CONSENT" = "Do Not Sell My Personal Information";

0 comments on commit ac8e1d9

Please sign in to comment.