Accessibility improvements of Edit Profile screen (#1180)

openedx-unsupported · Dec 7, 2018 · d6574b2 · d6574b2
1 parent ae8069c
commit d6574b2
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 3 deletions.
diff --git a/Source/IconButton.swift b/Source/IconButton.swift
@@ -71,4 +71,9 @@ class IconButton : UIControl {
         disabledAttributedString = disabledTitleStyle.attributedString(withText: title)
         titleLabel.attributedText = isEnabled ? enabledAttributedString : disabledAttributedString
     }
+
+    func setAccessibility(with trait: UIAccessibilityTraits, hint: String) {
+        titleLabel.accessibilityTraits = trait
+        titleLabel.accessibilityHint = hint
+    }
 }
diff --git a/Source/JSONFormBuilder.swift b/Source/JSONFormBuilder.swift
@@ -67,6 +67,9 @@ class JSONFormBuilder {
             descriptionLabel.textAlignment = .natural
             descriptionLabel.numberOfLines = 0
             descriptionLabel.preferredMaxLayoutWidth = 200 //value doesn't seem to matter as long as it's small enough
+
+            typeControl.tintColor = OEXStyles.shared().primaryBaseColor()
+            typeControl.setTitleTextAttributes([NSForegroundColorAttributeName: UIColor.white], for: UIControlState.selected)
 
             titleLabel.snp.makeConstraints { make in
                 make.leading.equalTo(contentView.snp.leadingMargin)

diff --git a/Source/ProfileBanner.swift b/Source/ProfileBanner.swift
@@ -60,7 +60,7 @@ class ProfileBanner: UIView {
             addSubview(changeButton)
 
             changeButton.setIconAndTitle(icon: Icon.Camera, title: Strings.Profile.changePictureButton)
-            changeButton.accessibilityHint = Strings.Profile.changePictureAccessibilityHint
+            changeButton.setAccessibility(with: UIAccessibilityTraitButton, hint: Strings.Profile.changePictureAccessibilityHint)
 
             changeButton.snp.makeConstraints { make in
                 make.centerY.equalTo(shortProfView)

diff --git a/Source/en.lproj/Localizable.strings b/Source/en.lproj/Localizable.strings
@@ -593,7 +593,7 @@
 /* Button title for moving to the next unit in the course */
 "PREVIOUS_UNIT" = "Previous Unit";
 /* A10y hint for the change picture button. */
-"PROFILE.CHANGE_PICTURE_ACCESSIBILITY_HINT" = "Upload a new profile picture.";
+"PROFILE.CHANGE_PICTURE_ACCESSIBILITY_HINT" = "Double tap to change profile photo";
 /* Change picture button text on edit profile screen. */
 "PROFILE.CHANGE_PICTURE_BUTTON" = "Change";
 /* Text for use a photo already in library for user profile photo alert */

diff --git a/Source/es-419.lproj/Localizable.strings b/Source/es-419.lproj/Localizable.strings
@@ -593,7 +593,7 @@
 /* Button title for moving to the next unit in the course */
 "PREVIOUS_UNIT" = "Unidad anterior";
 /* A10y hint for the change picture button. */
-"PROFILE.CHANGE_PICTURE_ACCESSIBILITY_HINT" = "Cargue una nueva foto de perfil";
+"PROFILE.CHANGE_PICTURE_ACCESSIBILITY_HINT" = "Double tap to change profile photo";
 /* Change picture button text on edit profile screen. */
 "PROFILE.CHANGE_PICTURE_BUTTON" = "Cambiar";
 /* Text for use a photo already in library for user profile photo alert */