This repository has been archived by the owner on May 6, 2024. It is now read-only.
chore: update chromecast for app nav #1811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumer92
force-pushed
the
umer/LEARNER-9688
branch
from
4206289
to
d782389
Compare
saeedbashir
suggested changes
Nov 15, 2023
Figure out the issue now it's compiling at my end. |
saeedbashir
approved these changes
Nov 16, 2023
|
QA team was able to test this out on Chromecast, closing this PR after their approval. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LEARNER-9688
This PR updates Chromecast for the App Nav. Chromecast button is shown on video screen, and if casting is being done for a video of same course, CourseDashboard shows cast button.
Playing video on chromecast
RPReplay_Final1700027787.MP4
When chromecast is not available.