Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

fix: Add Support For Hours, Minutes and Seconds in Dates #1827

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

shafqat-muneer
Copy link
Contributor

Description

LEARNER-9936

Implemented support for hours, minutes, and seconds in dates to prevent calendar synchronization update alerts when replacing the production application with the new codebase.

Prior to merging this PR, all calendar events were being added to the mobile native calendar at the timestamp of 04:00AM to 05:00AM because we were previously disregarding hours, minutes, and seconds. Therefore, we are now taking them into account, ensuring that calendar events are added at the exact time received from the backend.

Before After
Simulator Screenshot - iPhone 15 - 2024-04-19 at 18 00 31 Simulator Screenshot - iPhone 15 - 2024-04-19 at 17 51 47
Simulator Screenshot - iPhone 15 - 2024-04-19 at 18 00 35 Simulator Screenshot - iPhone 15 - 2024-04-19 at 17 51 53

How to test this PR

We can assess it by observing the behavior of the production application and then comparing it with the behavior on this branch.

@shafqat-muneer shafqat-muneer merged commit 5251050 into master Apr 22, 2024
2 of 6 checks passed
@shafqat-muneer shafqat-muneer deleted the Shafqat/LEARNER-9936 branch April 22, 2024 07:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants