chore: add python slugify to prod #600
Conversation
varshamenon4
force-pushed
the
varshamenon4/add-slugify-to-prod
branch
from
f7d7ca1
to
cc1e500
Compare
There was a problem hiding this comment.
There are a lot of other dependency upgrades in here. I feel like that can get a little cluttered to review outside of a Python requirements upgrade pull request. Are you able to just include the installation of python-slugify? I usually manually modify the upgrade Make target to remove the --upgrade flag to avoid upgrading all the dependencies. But let me know if you think the pain isn't worth it.
requirements/common_constraints.txt
Outdated
| @@ -3,6 +3,11 @@ | |||
| # See BOM-2721 for more details. | |||
| # Below is the copied and edited version of common_constraints | |||
|
|
|||
| # This is a temporary solution to override the real common_constraints.txt | |||
There was a problem hiding this comment.
It seems this paragraph was duplicated. Did you use make upgrade? I think we could probably remove this paragraph, right?
There was a problem hiding this comment.
I like your suggestion above to remove all extraneous upgrades, hopefully that will remove this as well! I'll do that!
varshamenon4
force-pushed
the
varshamenon4/add-slugify-to-prod
branch
2 times, most recently
from
d2fbcc4
to
cc1e500
Compare
varshamenon4
force-pushed
the
varshamenon4/add-slugify-to-prod
branch
from
16ba0ce
to
664550b
Compare
Add python-slugify to production so that sync_to_discovery management command works.