-
Notifications
You must be signed in to change notification settings - Fork 26
chore: add catalog info #620
chore: add catalog info #620
Conversation
Thanks for the pull request, @ichintanjoshi! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ichintanjoshi - looks like there's some yaml linting errors on the catalog-info. You should check those, and make sure any errors are corrected on other PRs.
Yes @sarina on it |
23328ae
to
2865ed2
Compare
Updated linting @sarina |
hey @ichintanjoshi I am waiting in #621 as well as in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ichintanjoshi - I can't seem to edit your branch. Could you do the following, then I will merge?
- Rebase the branch on master
- Squash to two commits (
chore: add catalog-info.yml
andchore: enable github issues via config file
)
@sarina @ichintanjoshi - just following up on this. |
@sarina Have rebased |
@ichintanjoshi can you address this feedback from my last comment?
This will require an interactive rebase, not merging master into this branch. |
You will need to run
to get at the comments in your branch, and then use the commands in interactive rebase to move and squash commits. We follow a rebasing workflow so it is wise to get used to actually rebasing rather than merging in master. I can only squash your commits down to one commit via the GitHub UI, and I want to maintain the two different changes made in this branch. https://hackernoon.com/beginners-guide-to-interactive-rebasing-346a3f9c3a6d Alternatively, you can close this PR and make a new one with the changes properly separated out, although I think that's more work. |
chore: Updating Python Requirements (openedx-unsupported#617) chore: add catalog-info.yml chore: enable github issues via config file fix: change linting for catalog-info.yaml file docs: Update README * Remove outdated Travis CI badge * s/edX/Open edX/ * Add note about Tutor - currently unknown if this package works on Tutor, but Devstack is deprecated. chore: Drop codecov to 90, which is a sane amount
f1725c8
to
72b1b48
Compare
@ichintanjoshi Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
@sarina closing this as I think I messed up the rebasing part, will raise a new one |
Description