Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing xblock parameter in get_javascript_i18n_catalog_url | FC-0012 #702

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

OmarIthawi
Copy link
Member

@OmarIthawi OmarIthawi commented Dec 22, 2023

To match the Open edX LMS XBlockI18nService in test environments. Otherwise, tests in individual XBlock repositories will fail due to an incorrect definition in:

This does not affect production code but it's blocking other pull requests from getting merged:

Already tested and works with:

This pull request is part of the FC-0012 project which implements the Translation Infrastructure update OEP-58.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 22, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@feanil
Copy link
Contributor

feanil commented Jan 2, 2024

@OmarIthawi it looks like I don't have permissions to rebase this PR but it's out of date from the base branch. Can you rebase it and then I can merge and release it.

…_url`

To match the Open edX LMS XBlockI18nService in test environments.
@OmarIthawi
Copy link
Member Author

@feanil I've rebased this PR branch. Please let me know if anything else is needed.

@feanil feanil merged commit 73032b9 into openedx:master Jan 3, 2024
9 checks passed
@openedx-webhooks
Copy link

@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants