Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create dataset for tagging #118

Merged
merged 2 commits into from
Sep 4, 2024
Merged

feat: create dataset for tagging #118

merged 2 commits into from
Sep 4, 2024

Conversation

Ian2012
Copy link
Contributor

@Ian2012 Ian2012 commented Aug 28, 2024

Description

This PR creates a view for having easy access to the parsed course tags. The current implementation has the following structure:

SELECT *
FROM reporting.course_tags

Query id: f15260ac-1c29-40e7-8a61-ee7cae127c9c

   ┌─course_key─────────────────────────┬─course_name──────────┬─taxonomy_name────┬─tag────────────────────┬─lineage─────────────────────────────────┐
1. │ course-v1:OpenedX+DemoX+DemoCourse │ Open edX Demo Course │ Example Taxonomy │ Electronic instruments │ ['Electronic instruments']              │
2. │ course-v1:OpenedX+DemoX+DemoCourse │ Open edX Demo Course │ Example Taxonomy │ Percussion instruments │ ['Percussion instruments']              │
3. │ course-v1:OpenedX+DemoX+DemoCourse │ Open edX Demo Course │ Example Taxonomy │ Bowed strings          │ ['String instruments', 'Bowed strings'] │
   └────────────────────────────────────┴──────────────────────┴──────────────────┴────────────────────────┴─────────────────────────────────────────┘

3 rows in set. Elapsed: 0.014 sec.

Depends on: openedx/tutor-contrib-aspects#927

Note for reviewers

The CI step will never pass unless we install tutor-contrib-aspects from this branch: openedx/tutor-contrib-aspects#927.

As long as CI passes there, there is no need to pass CI here

@openedx-webhooks
Copy link

openedx-webhooks commented Aug 28, 2024

Thanks for the pull request, @Ian2012!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @bmtcril. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@Ian2012 Ian2012 marked this pull request as ready for review August 29, 2024 16:41
@Ian2012 Ian2012 force-pushed the cag/tags branch 4 times, most recently from 803f660 to d7c9299 Compare August 29, 2024 21:26
docs: add documentation for course_tags

fix: avoid tag duplication

fix: split subtags

fix: split subtags

fix: split subtags

tmp: try new datasets

fix: add sources

fix: add sources

fix: add sources

fix: add sources

fix: add sources

fix: add sources

fix: add sources

fix: add sources

fix: add sources

fix: add sources

fix: add sources

fix: add sources

fix: turn most_recent views into MV

fix: remove duplicated schema

fix: sink only object tag id

fix: sink only object tag id

fix: add value to most_recent_tags dataset

fix: add value to most_recent_tags dataset

feat: add taxonomy name for course_tags

fix: add final keywod to course tags

perf: migrate course tags to a dictionary

docs: update schema
@Ian2012 Ian2012 force-pushed the cag/tags branch 3 times, most recently from 29dc3f0 to 94c4cf4 Compare August 30, 2024 17:02
@Ian2012 Ian2012 merged commit 022a039 into main Sep 4, 2024
3 of 4 checks passed
@openedx-webhooks
Copy link

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@Ian2012 Ian2012 deleted the cag/tags branch September 4, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants