build: running tests using python 3.11 #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awais786
force-pushed
the
python-vers
branch
from
25f1375
to
df74ce6
Compare
awais786
commented
Mar 28, 2024
| @@ -161,7 +161,7 @@ requests==2.31.0 | |||
| # -r requirements/base.txt | |||
| # requests-oauthlib | |||
| # social-auth-core | |||
| requests-oauthlib==1.3.1 | |||
| requests-oauthlib==2.0.0 | |||
There was a problem hiding this comment.
changes seems fine here
awais786
changed the title
UsamaSadiq
approved these changes
Mar 29, 2024
| @@ -14,8 +14,8 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| os: [ubuntu-20.04] | |||
| python-version: ['3.8'] | |||
| toxenv: [quality, django32, django42, check_keywords] | |||
| python-version: ['3.8', '3.11', '3.12'] | |||
There was a problem hiding this comment.
Since we are upgrading to Python 3.11 now, we can skip running tests with 3.12 for now.
Suggested change
| python-version: ['3.8', '3.11', '3.12'] | |
| python-version: ['3.8', '3.11'] |
There was a problem hiding this comment.
I think since the tests are passing on both, we should run both, we'll want to drop 3.11 after we cut redwood almost immediately so best to start testing 3.12 where it's already passing.
CHANGELOG.rst
Outdated
| Added | ||
| ~~~~~~~ | ||
|
|
||
| [4.3.0] - 2024-02-13 |
There was a problem hiding this comment.
Suggested change
| [4.3.0] - 2024-02-13 | |
| [4.3.0] - 2024-03-29 |
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openedx/public-engineering#236
Running tests using python 3.11.