[191]: Upgrade to Python 3.12 #226
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdullahQureshee
force-pushed
the
maq/191
branch
2 times, most recently
from
7ec1299 to
0a51874
Compare
|
@irtazaakram I can't find a lot to change in this repo, for example, the changes here. Please guide me if I've missed any change in this PR. |
abdullahQureshee
force-pushed
the
maq/191
branch
from
0a51874 to
0556727
Compare
irtazaakram
suggested changes
Feb 20, 2025
Comment on lines
+16
to
23
| - python_version: '3.12' | ||
| ubuntu_version: '20.04' | ||
| os: "ubuntu-20.04" | ||
| - python_version: '3.11' | ||
| - python_version: '3.12' | ||
| ubuntu_version: '22.04' | ||
| os: "ubuntu-22.04" | ||
| - python_version: '3.11' | ||
| - python_version: '3.12' | ||
| ubuntu_version: '24.04' |
There was a problem hiding this comment.
We need to support both python 3.11 & 3.12 here
| @@ -53,5 +53,6 @@ def get_version(*file_paths): | |||
| 'Programming Language :: Python :: 3', | |||
| 'Programming Language :: Python :: 3.8', | |||
There was a problem hiding this comment.
let's drop all references/usage of python 3.8 here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.