fix: dependencies

openedx · Apr 8, 2024 · 5b89915 · 5b89915
1 parent 21c6f1f
commit 5b89915
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -12,7 +12,6 @@ jobs:
     name: Tests
     runs-on: ${{ matrix.os }}
     strategy:
-      fail-fast: false
       matrix:
         os: [ubuntu-20.04]
         python-version: ['3.8', '3.11', '3.12']

diff --git a/Makefile b/Makefile
@@ -63,6 +63,10 @@ upgrade: $(COMMON_CONSTRAINTS_TXT)  ## update the requirements/*.txt files with
 	# Let tox control the Django version for tests
 	sed '/^[dD]jango==/d' requirements/test.txt > requirements/test.tmp
 	mv requirements/test.tmp requirements/test.txt
+	# Also lets tox control DRF version
+	sed '/^[dD]jangorestframework==/d' requirements/test.txt > requirements/test.tmp
+	mv requirements/test.tmp requirements/test.txt
+
 
 quality: ## check coding style with pycodestyle and pylint
 	tox -e quality

diff --git a/requirements/test.txt b/requirements/test.txt
@@ -77,7 +77,7 @@ django-waffle==4.1.0
     #   edx-django-utils
     #   edx-drf-extensions
     #   edx-toggles
-djangorestframework==3.15.1
+
     # via
     #   -r requirements/base.in
     #   drf-jwt