Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove trailing comma that caused catalog-in fo.yaml to be invalid yaml #288

Closed
wants to merge 1 commit into from

Conversation

pomegranited
Copy link
Contributor

@pomegranited pomegranited commented Apr 1, 2024

Description: Fix to the catalog-info.yaml file added by #287

cf openedx/edx-submissions#234

Testing instructions: N/A

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped - N/A
  • Changelog record added - N/A
  • Documentation updated (not only docstrings) - N/A
  • Commits are squashed

Post merge:

  • Create a tag - N/A
  • Check new version is pushed to PyPi after tag-triggered build is finished. - N/A
  • Delete working branch (if not needed anymore)

@pomegranited pomegranited removed the request for review from feanil April 3, 2024 04:34
@pomegranited pomegranited enabled auto-merge (squash) April 3, 2024 04:35
@pomegranited
Copy link
Contributor Author

Hi @mphilbrick211 could you have a look at why my cla check is failing here? I don't think anything has changed since this check succeeded last week? #287

@sarina
Copy link
Contributor

sarina commented Apr 3, 2024

@pomegranited it doesn't look like the check is failing, it's just stalled, which I don't have a way to kick. Can you push an empty commit?

@pomegranited
Copy link
Contributor Author

@sarina Tried re-pushing, but same effect.. and I'm not sure where that check is triggered from (it must be in the repo settings, not the .github/workflows?)

@e0d
Copy link

e0d commented Apr 4, 2024

Commenting should rerun the cla check.

@e0d e0d changed the title fix: Remove trailing comma that caused catalog-info.yaml to be invalid yaml fix: Remove trailing comma that caused catalog-in fo.yaml to be invalid yaml Apr 4, 2024
@sarina
Copy link
Contributor

sarina commented Apr 4, 2024

@e0d huh, that's weird... because Jill & I did comment to no avail. Anyway thanks for the magic comment 🪄 !

@e0d
Copy link

e0d commented Apr 4, 2024

@e0d huh, that's weird... because Jill & I did comment to no avail. Anyway thanks for the magic comment 🪄 !

I don't think my comment worked 😞 I think there's something weirdly stuck here. I'd try a new branch and PR.

@pomegranited
Copy link
Contributor Author

Closed in favour of #291

auto-merge was automatically disabled April 4, 2024 01:40

Pull request was closed

@pomegranited pomegranited deleted the jill/fix-catalog-info branch April 4, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants