feat!: Django 4.0 and above, CSRF_TRUSTED_ORIGINS must include schemes. #4127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamsobanjaved
approved these changes
Sep 26, 2023
DawoudSheraz
approved these changes
Sep 27, 2023
timmc-edx
reviewed
Sep 27, 2023
Comment on lines
+96
to
+97
| if django.VERSION[0] >= 4: # for greater than django 3.2 use schemes. | ||
| CSRF_TRUSTED_ORIGINS = CSRF_TRUSTED_ORIGINS_WITH_SCHEME |
There was a problem hiding this comment.
I believe this is breaking devstack provisioning -- see #4133 for a possible fix.
EDIT: This seems to have fixed it.
There was a problem hiding this comment.
Thank you @timmc-edx . Apologies that the base settings were missed out/ignored in this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
edx/edx-arch-experiments#459
django4.0 = https://docs.djangoproject.com/en/4.0/ref/settings/#csrf-trusted-origins
django3.2 = https://docs.djangoproject.com/en/3.2/ref/settings/#csrf-trusted-origins
Internal PR
https://github.com/edx/edx-internal/pull/9272/files