Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Django to 4.2.16 for Redwood - Security Patch #4440

Conversation

magajh
Copy link
Contributor

@magajh magajh commented Sep 10, 2024

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 10, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @magajh!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/course-discovery-admins. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@magajh magajh force-pushed the magajh/patch-django-redwood-4.2.16 branch from 8314c1f to 21635a2 Compare September 10, 2024 09:44
@cmltaWt0
Copy link
Contributor

@magajh I've tested the build via tutor build.
Do you have an idea why we have failing tests for python3.8?

@cmltaWt0
Copy link
Contributor

I believe we can igrone the python3.8 fails due to #4439

@magajh magajh force-pushed the magajh/patch-django-redwood-4.2.16 branch from 21635a2 to 6221ab4 Compare October 17, 2024 22:49
@cmltaWt0
Copy link
Contributor

@feanil Could you please remind me of the python version support for Redwood. I believe we do not support python3.8 on Redwood.

@magajh magajh force-pushed the magajh/patch-django-redwood-4.2.16 branch 3 times, most recently from 8c80b5a to 6221ab4 Compare October 21, 2024 11:44
@magajh
Copy link
Contributor Author

magajh commented Oct 21, 2024

@cmltaWt0 not really sure why this is failing now, but it seems to be an issue with the packaging library version in local.txt used for running the tests. The project is using version 21.3, which does not accept the argument causing the error. I tried upgrading to version 22.0, but I encountered some incompatibility issues because some dependencies require <=21.3
https://github.com/openedx/course-discovery/actions/runs/11439129610/job/31822159616?pr=4440

The good news is that according to this comment we can safely ignore the python3.8 failures: #4450 (comment) 🥇

@cmltaWt0
Copy link
Contributor

@feanil Could you please remind me of the python version support for Redwood. I believe we do not support python3.8 on Redwood.

@cmltaWt0 not really sure why this is failing now, but it seems to be an issue with the packaging library version in local.txt used for running the tests. The project is using version 21.3, which does not accept the argument causing the error. I tried upgrading to version 22.0, but I encountered some incompatibility issues because some dependencies require <=21.3 https://github.com/openedx/course-discovery/actions/runs/11439129610/job/31822159616?pr=4440

The good news is that according to this comment we can safely ignore the python3.8 failures: #4450 (comment) 🥇

Ohh, I didn't see that comment. So it's really looks like we can ignore the python3.8 support 👍

@cmltaWt0
Copy link
Contributor

cmltaWt0 commented Oct 21, 2024

@feanil Could you please remind me of the python version support for Redwood. I believe we do not support python3.8 on Redwood.

UPD:

@cmltaWt0 not really sure why this is failing now, but it seems to be an issue with the packaging library version in local.txt used for running the tests. The project is using version 21.3, which does not accept the argument causing the error. I tried upgrading to version 22.0, but I encountered some incompatibility issues because some dependencies require <=21.3 https://github.com/openedx/course-discovery/actions/runs/11439129610/job/31822159616?pr=4440

The good news is that according to this comment we can safely ignore the python3.8 failures: #4450 (comment) 🥇

Ohh, I didn't see that comment. So it's really looks like we can ignore the python3.8 support 👍

@cmltaWt0 cmltaWt0 merged commit 3bfd29a into openedx:open-release/redwood.master Oct 21, 2024
58 of 76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants