Get spanish translations from active subjects #4445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamza-56
requested review from
DawoudSheraz,
Ali-D-Akbar,
AfaqShuaib09 and
zawan-ila
| @@ -116,7 +116,7 @@ def get_products(self, product_type, product_source): | |||
| ).filter(Q(num_orgs__gt=0) & Q(card_image__isnull=False) & ~Q(card_image='')) | |||
|
|
|||
| subject_translations = Prefetch( | |||
| 'courses__subjects__translations', | |||
| 'active_subjects__translations', | |||
There was a problem hiding this comment.
This argument should be lookup, I don't think active subjects (a property) would work here.
There was a problem hiding this comment.
I tested it locally, and it appears to be working fine.
AfaqShuaib09
approved these changes
Sep 16, 2024
Ali-D-Akbar
approved these changes
Sep 18, 2024
hamza-56
force-pushed
the
hamza/get-spanish-translations-from-active-subjects
branch
from
8d1c503
to
43d5e2f
Compare
Ali-D-Akbar
approved these changes
Sep 18, 2024
hamza-56
force-pushed
the
hamza/get-spanish-translations-from-active-subjects
branch
from
43d5e2f
to
2c569c2
Compare
AfaqShuaib09
approved these changes
Sep 18, 2024
hamza-56
deleted the
hamza/get-spanish-translations-from-active-subjects
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
populate_product_catalogcommand to get Spanish translations from active subjects