build: Remove tests/ stub; make make test-all work right
#402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The `tests/__init__.py` create/delete thing seems to have been a workaround for something that's no longer relevant, so just remove it. - The `test-all` target needed to depend on `clean` so that `build/lib` wouldn't stick around and confuse pytest, and the recipe needed to be pruned down to just `tox` because otherwise we'd run the quality checks twice. (`quality` is in the tox.ini default env list.)
robrap
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Is https://github.com/openedx/edx-django-utils/blob/master/test_utils/__init__.py still relevant as well?
|
Good find -- I can remove test_utils as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests/__init__.pycreate/delete thing seems to have been a workaround for something that's no longer relevant, so just remove it.test-alltarget needed to depend oncleanso thatbuild/libwouldn't stick around and confuse pytest, and the recipe needed to be pruned down to justtoxbecause otherwise we'd run the quality checks twice. (qualityis in the tox.ini default env list.)Merge checklist: