Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Remove tests/ stub; make make test-all work right #402

Merged
merged 2 commits into from
Apr 3, 2024
Merged

build: Remove tests/ stub; make make test-all work right #402

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50dadaa
build: Remove tests/ stub; make `make test-all` work right
timmc-edx Mar 29, 2024
de46989
fixup! Remove test_utils as well (unused, from cookiecutter)
timmc-edx Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,6 @@ docs/edx_django_utils.*.rst
requirements/private.in
requirements/private.txt

# tox environment temporary artifacts
tests/__init__.py

# Development task artifacts
default.db

Expand Down
3 changes: 1 addition & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,7 @@ test: clean ## run tests in the current virtualenv
diff_cover: test ## find diff lines that need test coverage
diff-cover coverage.xml

test-all: ## run tests on every supported Python/Django combination
tox -e quality
test-all: clean ## run quality checks as well as tests on every supported Python/Django combination
tox

validate: quality test ## run tests and quality checks
Expand Down
4 changes: 0 additions & 4 deletions tests/test_models.py
View file
Open in desktop

This file was deleted.

12 changes: 5 additions & 7 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,10 @@ deps =
-r{toxinidir}/requirements/quality.txt
setuptools
commands =
touch tests/__init__.py
pylint edx_django_utils tests test_utils manage.py setup.py
rm tests/__init__.py
pycodestyle edx_django_utils tests manage.py setup.py
pydocstyle edx_django_utils tests manage.py setup.py
isort --check-only --diff tests test_utils edx_django_utils manage.py setup.py test_settings.py
pylint edx_django_utils test_utils manage.py setup.py
pycodestyle edx_django_utils manage.py setup.py
pydocstyle edx_django_utils manage.py setup.py
isort --check-only --diff test_utils edx_django_utils manage.py setup.py test_settings.py
make selfcheck

[testenv:isort]
Expand All @@ -90,4 +88,4 @@ allowlist_externals =
deps =
-r{toxinidir}/requirements/quality.txt
commands =
isort tests test_utils edx_django_utils manage.py setup.py test_settings.py
isort test_utils edx_django_utils manage.py setup.py test_settings.py
Loading