Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: drop python 3.8 support #474

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-20.04]
python-version: ['3.8', '3.11']
python-version: ['3.11']
toxenv: [quality, docs, django42-drflatest]

steps:
Expand All @@ -34,7 +34,7 @@ jobs:
run: tox

- name: Run coverage
if: matrix.python-version == '3.8' && matrix.toxenv == 'django42-drflatest'
if: matrix.python-version == '3.11' && matrix.toxenv == 'django42-drflatest'
uses: codecov/codecov-action@v4
with:
token: ${{ secrets.CODECOV_TOKEN }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pypi-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- name: setup python
uses: actions/setup-python@v5
with:
python-version: 3.8
python-version: 3.11

- name: Install pip
run: pip install -r requirements/pip.txt
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -72,3 +72,4 @@ test.tmp

# vscode
.vscode
venv
2 changes: 1 addition & 1 deletion .readthedocs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ version: 2
build:
os: "ubuntu-22.04"
tools:
python: "3.8"
python: "3.11"

# Build documentation in the docs/ directory with Sphinx
sphinx:
Expand Down
3 changes: 2 additions & 1 deletion edx_rest_framework_extensions/auth/jwt/middleware.py
Original file line number Diff line number Diff line change
Expand Up @@ -227,9 +227,10 @@ def process_view(self, request, view_func, view_args, view_kwargs): # pylint: d
# Log unexpected case of only finding one cookie.
if not header_payload_cookie:
log_message = self._get_missing_cookie_message(jwt_cookie_header_payload_name())
log.warning(log_message)
if not signature_cookie:
log_message = self._get_missing_cookie_message(jwt_cookie_signature_name())
log.warning(log_message)
log.warning(log_message)

has_reconstituted_jwt_cookie = jwt_cookie_name() in request.COOKIES
# .. custom_attribute_name: has_jwt_cookie
Expand Down
49 changes: 22 additions & 27 deletions requirements/base.txt
Original file line number Diff line number Diff line change
@@ -1,29 +1,24 @@
#
# This file is autogenerated by pip-compile with Python 3.8
# This file is autogenerated by pip-compile with Python 3.11
# by the following command:
#
# make upgrade
#
asgiref==3.8.1
# via django
backports-zoneinfo==0.2.1 ; python_version < "3.9"
# via
# -c requirements/constraints.txt
# django
# djangorestframework
certifi==2024.2.2
certifi==2024.7.4
# via requests
cffi==1.16.0
cffi==1.17.0
# via
# cryptography
# pynacl
charset-normalizer==3.3.2
# via requests
click==8.1.7
# via edx-django-utils
cryptography==42.0.5
cryptography==43.0.0
# via pyjwt
django==4.2.11
django==4.2.15
# via
# -c requirements/common_constraints.txt
# -r requirements/base.in
Expand All @@ -38,47 +33,47 @@ django-waffle==4.1.0
# via
# -r requirements/base.in
# edx-django-utils
djangorestframework==3.15.1
djangorestframework==3.15.2
# via
# -r requirements/base.in
# drf-jwt
dnspython==2.6.1
# via pymongo
drf-jwt==1.19.2
# via -r requirements/base.in
edx-django-utils==5.11.0
edx-django-utils==5.15.0
# via -r requirements/base.in
edx-opaque-keys==2.5.1
edx-opaque-keys==2.10.0
# via -r requirements/base.in
idna==3.6
idna==3.7
# via requests
newrelic==9.8.0
newrelic==9.13.0
# via edx-django-utils
pbr==6.0.0
# via stevedore
psutil==5.9.8
psutil==6.0.0
# via edx-django-utils
pycparser==2.21
pycparser==2.22
# via cffi
pyjwt[crypto]==2.8.0
pyjwt[crypto]==2.9.0
# via
# -r requirements/base.in
# drf-jwt
pymongo==3.13.0
pymongo==4.8.0
# via edx-opaque-keys
pynacl==1.5.0
# via edx-django-utils
requests==2.31.0
requests==2.32.3
# via -r requirements/base.in
semantic-version==2.10.0
# via -r requirements/base.in
sqlparse==0.4.4
sqlparse==0.5.1
# via django
stevedore==5.2.0
stevedore==5.3.0
# via
# edx-django-utils
# edx-opaque-keys
typing-extensions==4.10.0
# via
# asgiref
# edx-opaque-keys
urllib3==2.2.1
typing-extensions==4.12.2
# via edx-opaque-keys
urllib3==2.2.2
# via requests
15 changes: 7 additions & 8 deletions requirements/common_constraints.txt
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,15 @@ Django<5.0

# elasticsearch>=7.14.0 includes breaking changes in it which caused issues in discovery upgrade process.
# elastic search changelog: https://www.elastic.co/guide/en/enterprise-search/master/release-notes-7.14.0.html
# See https://github.com/openedx/edx-platform/issues/35126 for more info
elasticsearch<7.14.0

# django-simple-history>3.0.0 adds indexing and causes a lot of migrations to be affected
django-simple-history==3.0.0

# opentelemetry requires version 6.x at the moment:
# https://github.com/open-telemetry/opentelemetry-python/issues/3570
# Normally this could be added as a constraint in edx-django-utils, where we're
# adding the opentelemetry dependency. However, when we compile pip-tools.txt,
# that uses version 7.x, and then there's no undoing that when compiling base.txt.
# So we need to pin it globally, for now.
# Ticket for unpinning: https://github.com/openedx/edx-lint/issues/407
importlib-metadata<7
# Cause: https://github.com/openedx/event-tracking/pull/290
# event-tracking 2.4.1 upgrades to pymongo 4.4.0 which is not supported on edx-platform.
# We will pin event-tracking to do not break existing installations
# This can be unpinned once https://github.com/openedx/edx-platform/issues/34586
# has been resolved and edx-platform is running with pymongo>=4.4.0
event-tracking<2.4.1
Loading