Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: discovery work into implementing integrated skills content #1792

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alex-sheehan-edx
Copy link
Contributor

https://2u-internal.atlassian.net/browse/ENT-7324

Merge checklist:

  • Any new requirements are in the right place (do not manually modify the requirements/*.txt files)
    • base.in if needed in production but edx-platform doesn't install it
    • test-master.in if edx-platform pins it, with a matching version
    • make upgrade && make requirements have been run to regenerate requirements
  • make static has been run to update webpack bundling if any static content was updated
  • ./manage.py makemigrations has been run
    • Checkout the Database Migration Confluence page for helpful tips on creating migrations.
    • Note: This must be run if you modified any models.
      • It may or may not make a migration depending on exactly what you modified, but it should still be run.
    • This should be run from either a venv with all the lms/edx-enterprise requirements installed or if you checked out edx-enterprise into the src directory used by lms, you can run this command through an lms shell.
      • It would be ./manage.py lms makemigrations in the shell.
  • Version bumped
  • Changelog record added
  • Translations updated (see docs/internationalization.rst but also this isn't blocking for merge atm)

Post merge:

  • Tag pushed and a new version released
    • Note: Assets will be added automatically. You just need to provide a tag (should match your version number) and title and description.
  • After versioned build finishes in GitHub Actions, verify version has been pushed to PyPI
    • Each step in the release build has a condition flag that checks if the rest of the steps are done and if so will deploy to PyPi.
      (so basically once your build finishes, after maybe a minute you should see the new version in PyPi automatically (on refresh))
  • PR created in edx-platform to upgrade dependencies (including edx-enterprise)
    • This must be done after the version is visible in PyPi as make upgrade in edx-platform will look for the latest version in PyPi.
    • Note: the edx-enterprise constraint in edx-platform must also be bumped to the latest version in PyPi.

@alex-sheehan-edx alex-sheehan-edx requested review from johnnagro, bcitro and a team July 6, 2023 17:57
@alex-sheehan-edx alex-sheehan-edx force-pushed the asheehan-edx/integrated-channels-skills branch from 2ee7e0a to a0a66fb Compare July 6, 2023 18:01
@alex-sheehan-edx
Copy link
Contributor Author

My primary concerns/questions to reviewers are:

  1. where to implement channel specific support for skills
    meaning I'm thinking about where do we cut off unsupported channels in the skill exporting/transmitting process? (re https://github.com/openedx/edx-enterprise/pull/1792/files#diff-bd1856bd7ffab338eb216ef940de368327f49152f8673cc007eac15557220c78R592).
  2. Is my associated_catalog_keys = models.ManyToManyField approach to the skills transmission audit table efficient enough to support the look ups in the exporter ?

@alex-sheehan-edx alex-sheehan-edx marked this pull request as draft July 6, 2023 18:09
# create, update, delete, skills_metadata, relations_metadata = exporter.export()
# transmitter.transmit(create, update, delete)
# transmitter.transmit_skills(skills_metadata)
# transmitter.transmit_skill_associations(relations_metadata)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could also deal with channel support/order of operations here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant