-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: per-user secured Algolia API keys [BB-8083] #1962
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @0x29a! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently unmaintained. To get help with finding a technical reviewer, tag the community contributions project manager for this PR in a comment and let them know that your changes are ready for review:
Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
529ace0
to
4281496
Compare
4281496
to
04df3a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- I tested this: in feat: per-user secured Algolia API keys [BB-8083] open-craft/edx-enterprise#11, which is a clean cherry-pick (except for the requirements changes)
- I read through the code
- I checked for accessibility issues: n/a
- Includes documentation: n/a
I've run the tests and added @0x29a to the triage group so that test will run automatically going forward. |
Clicked the wrong button :) |
@0x29a Looks like there are some failed tests, can you please have a look? |
c5fdfdb
to
23b1317
Compare
23b1317
to
6247ed4
Compare
Thank you for adding me to the triage group, @e0d. 🙂
Yep, the newer version, to which I cherry-picked this change, doesn't import gettext anymore. I fixed this. |
Hi @openedx/2u-titans! If you're still reviewing pull requests, would you be able to please review / merge this for us? Thanks! |
Description
Adds a new endpoint that generates a secured Algolia API key capable of retrieving only data that is associated with enterprises linked to a requesting user. This is useful when you want to isolate enterprise learners, so they can't modify underlying Algolia requests to fetch the whole index content.
Testing steps
See openedx/frontend-app-learner-portal-enterprise#887