-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: enable CI for pull requests #1978
base: master
Are you sure you want to change the base?
build: enable CI for pull requests #1978
Conversation
Thanks for the pull request, @0x29a! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently unmaintained. To get help with finding a technical reviewer, tag the community contributions project manager for this PR in a comment and let them know that your changes are ready for review:
Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- I tested this: we've been applying this change manually to our branches since Nutmeg
- I read through the code
- I checked for accessibility issues: n/a
- Includes documentation: n/a
@e0d, would you be able to help with merging this? |
@georgebabey any reason not to merge this? |
Hi @georgebabey - bumping this! |
@georgebabey, @mphilbrick211, just checking: if the change if fine, can we possibly merge this? Here is an example of a chained pull request where this fix would be helpful. You can see that tests aren't being run for it. |
Hi @0x29a - I'm looking into getting this reviewed for you. |
Apologies for the delay, happy to get this merged, but it is out of date with base branch now |
010a7e8
to
b8e901b
Compare
Thank you, @georgebabey and @mphilbrick211! I re-based the branch. |
b8e901b
to
ccc68ae
Compare
13af747
to
53bf5c5
Compare
@georgebabey Could you please hit merge here? |
@bradenmacdonald I noticed the branch is out of date, can you update? |
…non-master-branches
@e0d Sure, I pressed the update button. That's weird you couldn't, because I know GitHub has functionality to allow maintainers to update PRs even from private forks. I've used it myself as a maintainer on other projects. Maybe there's a setting we need to turn on for this repo? |
…non-master-branches
This change enables CI checks for PRs targeted against branches other than
master
.This is useful for stacked PRs, as it allows to run checks for all dependent PRs.