feat: Pin importlib-metadata globally for opentelemetry #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be needed for openedx/edx-django-utils#389
timmc-edx
added a commit
to openedx/edx-django-utils
that referenced
this pull request
Mar 12, 2024
Temporary constraint needs to be removed before this merges; see openedx/edx-lint#406
robrap
reviewed
Mar 12, 2024
| # adding the opentelemetry dependency. However, when we compile pip-tools.txt, | ||
| # that uses version 7.x, and then there's no undoing that when compiling base.txt. | ||
| # So we need to pin it globally, for now. | ||
| importlib-metadata<7 |
There was a problem hiding this comment.
Can we add a ticket reference for resolving?
There was a problem hiding this comment.
Yep, can do. I wasn't sure whether to create one since it's a high-visibility pin (not tucked away in just one IDA's constraints file) but -- better to create one.
robrap
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be needed for openedx/edx-django-utils#389