Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: install pkg-config for PyMySQL compatibility #339

Merged
merged 1 commit into from
Jul 6, 2023
Merged

chore: install pkg-config for PyMySQL compatibility #339

merged 1 commit into from
Jul 6, 2023

Conversation

leangseu-edx
Copy link
Contributor

@leangseu-edx leangseu-edx commented Jul 6, 2023 •
edited
Loading

@leangseu-edx leangseu-edx requested a review from a team as a code owner July 6, 2023 12:50
@leangseu-edx leangseu-edx mentioned this pull request Jul 6, 2023
Closed
27 tasks
@timmc-edx
Copy link
Contributor

Same recommendations here about DEBIAN_FRONTEND=noninteractive and/or --no-install-recommends being needed, and optionally a comment describing which packages are needed for what.

@leangseu-edx
Copy link
Contributor Author

Same recommendations here about DEBIAN_FRONTEND=noninteractive and/or --no-install-recommends being needed, and optionally a comment describing which packages are needed for what.

I built this dockerfile. It seems to work without those option.

timmc-edx
timmc-edx approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@timmc-edx timmc-edx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, interesting! I'd like to understand why it's a problem for some dockerfiles and not others. But if it works, that's good enough for me. :-)

mattcarter
mattcarter approved these changes Jul 6, 2023
View reviewed changes
Copy link

@mattcarter mattcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the container runs correctly w/o the config changes, LGTM 👍🏻

@leangseu-edx leangseu-edx merged commit e0c5ec8 into master Jul 6, 2023
@leangseu-edx leangseu-edx deleted the lk/dockerfile-pkg-config branch July 6, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timmc-edx timmc-edx timmc-edx approved these changes

@mattcarter mattcarter mattcarter approved these changes

@jansenk jansenk Awaiting requested review from jansenk

@muselesscreator muselesscreator Awaiting requested review from muselesscreator

@nsprenkle nsprenkle Awaiting requested review from nsprenkle

@jszewczulak jszewczulak Awaiting requested review from jszewczulak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leangseu-edx @timmc-edx @mattcarter