fix: feedback

openedx · Oct 8, 2024 · 90f5924 · 90f5924
1 parent 7fae713
commit 90f5924
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/cms/djangoapps/contentstore/tests/test_filters.py b/cms/djangoapps/contentstore/tests/test_filters.py
@@ -58,8 +58,8 @@ def setUp(self):  # pylint: disable=arguments-differ
     )
     def test_lms_url_requested_filter_executed(self):
         """
-        Test whether the lms url requested filter is triggered before the user's
-        render site process.
+        Test that filter get new LMS URL for asset URL generation
+        based on the course organization settings for org.
         Expected result:
             - LMSPageURLRequested is triggered and executes TestPageURLRequestedPipelineStep.
             - The arguments that the receiver gets are the arguments used by the filter.
@@ -79,10 +79,10 @@ def test_lms_url_requested_filter_executed(self):
     @override_settings(OPEN_EDX_FILTERS_CONFIG={}, LMS_ROOT_URL="https://lms-base")
     def test_lms_url_requested_without_filter_configuration(self):
         """
-        Test usual get link for about page process, without filter's intervention.
+        Test that filter get new LMS URL for asset URL generation
+        based on LMS_ROOT_URL settings because OPEN_EDX_FILTERS_CONFIG is not set.
         Expected result:
-            - Returns the course sharing url, this can be one of course's social sharing url, marketing url, or
-                lms course about url.
+            - Returns the asset URL with domain base LMS_ROOT_URL.
             - The get process ends successfully.
         """
         output = asset_storage_handlers.get_asset_json(

diff --git a/common/djangoapps/util/tests/test_filters.py b/common/djangoapps/util/tests/test_filters.py
@@ -27,7 +27,7 @@ def run_filter(self, url, org):  # pylint: disable=arguments-differ
 @skip_unless_lms
 class CourseAboutPageURLRequestedFiltersTest(ModuleStoreTestCase):
     """
-    Tests for the Open edX Filters associated with the lms url creation process.
+    Tests for the Open edX Filters associated with the course about page url requested.
     This class guarantees that the following filters are triggered during the microsite render:
     - CourseAboutPageURLRequested
     """
@@ -48,8 +48,8 @@ def setUp(self):  # pylint: disable=arguments-differ
     )
     def test_course_about_page_url_requested_filter_executed(self):
         """
-        Test whether the lms url requested filter is triggered before the user's
-        render site process.
+        Test that filter get new course about URL based
+        on the course organization settings for org.
         Expected result:
             - CourseAboutPageURLRequested is triggered and executes TestPageURLRequestedPipelineStep.
             - The arguments that the receiver gets are the arguments used by the filter.
@@ -61,10 +61,10 @@ def test_course_about_page_url_requested_filter_executed(self):
     @override_settings(OPEN_EDX_FILTERS_CONFIG={}, LMS_ROOT_URL="https://lms-base")
     def test_course_about_page_url_requested_without_filter_configuration(self):
         """
-        Test usual get link for about page process, without filter's intervention.
+        Test that filter get new course about URL based
+        on the LMS_ROOT_URL settings because OPEN_EDX_FILTERS_CONFIG is not set.
         Expected result:
-            - Returns the course sharing url, this can be one of course's social sharing url, marketing url, or
-                lms course about url.
+            - Returns the course about URL with domain base LMS_ROOT_URL.
             - The get process ends successfully.
         """
         course_about_url = course.get_link_for_about_page(self.course)