Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade django-storages #31176

Closed
iamsobanjaved opened this issue Oct 19, 2022 · 3 comments
Closed

Upgrade django-storages #31176

iamsobanjaved opened this issue Oct 19, 2022 · 3 comments

Comments

@iamsobanjaved
Copy link
Contributor

iamsobanjaved commented Oct 19, 2022

We have currently pinned django-storages to less than 1.9 version due to usage of boto, as support of boto is dropped from the newer versions django-storages. Removal of boto is ticketed in #31175, so this issue will be unblocked once that is completed.

Blocked By
#31175 ( its not a blocker any more we have upgraded exceptions )

Copy of
https://2u-internal.atlassian.net/browse/BOM-3359

@iamsobanjaved iamsobanjaved moved this to Blocked in Arbi-BOM Oct 19, 2022
@awais786 awais786 moved this from Blocked to In Progress in Arbi-BOM Jun 2, 2023
@awais786
Copy link
Contributor

1.9.1 is working fine now for further upgrade we need to change multiple settings.

next taget is 1.10.1 https://github.com/jschneier/django-storages/blob/master/CHANGELOG.rst#1101-2020-09-13

@awais786
Copy link
Contributor

awais786 commented Jul 6, 2023

In 1.10.1 I found that it verifies the params which are passing to s3boto3 and headers is not a valid settings.
Here you can see it is passing options to storage and it triggers error

Same thing happen with videos.
https://github.com/openedx/edx-val/blob/edf2e37bfbab3133aed5dc738e5ac8d6bfa84ee6/edxval/utils.py#L160

It means cachecontrol: maxage is not working via code. Its coming from bucket or cloudfare. This needs a proper fix and communication with owning team.

@awais786
Copy link
Contributor

django-storages upgraded to it max with django4.2 support.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Arbi-BOM Sep 25, 2023
@jristau1984 jristau1984 moved this from Done to Done - Long Term Storage in Arbi-BOM Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants