Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updating bucket to bucket_name. These are deprecated. #32533

Merged
merged 4 commits into from
Jun 22, 2023

Conversation

awais786
Copy link
Contributor

@awais786 awais786 commented Jun 21, 2023

Part 1:
It will take multiple prs in platform and edx-internal.

Its an effort to update django-storages to latest version. Right now we are using 1.9.1 but for further upgrades there are some settings which need upgrade.

https://github.com/jschneier/django-storages/blob/master/CHANGELOG.rst#17-2018-09-03

The long aliased arguments to S3Boto3Storage of acl and bucket are deprecated in favor of bucket_name and default_acl.

Issue information.

Next step is to make changes in edx-internal repos.

1: https://github.com/edx/edx-internal/pull/8629

@awais786 awais786 marked this pull request as ready for review June 21, 2023 09:48
@awais786 awais786 requested a review from jmbowman June 21, 2023 11:42
@awais786 awais786 merged commit 92cba6c into master Jun 22, 2023
@awais786 awais786 deleted the rename_bucket_settings branch June 22, 2023 11:14
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants