Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action Required: Fix Renovate Configuration #34940

Closed
renovate bot opened this issue Jun 6, 2024 · 2 comments · Fixed by #34944
Closed

Action Required: Fix Renovate Configuration #34940

renovate bot opened this issue Jun 6, 2024 · 2 comments · Fixed by #34944
Assignees
@kdmccormick

Comments

@renovate
Copy link
Contributor

renovate bot commented Jun 6, 2024

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Location: .github/renovate.json
Error type: The renovate configuration file contains some invalid settings
Message: Invalid configuration option: Open_edX_ignoreDeps_reasons
@feanil feanil mentioned this issue Jun 7, 2024
Merged
@feanil
Copy link
Contributor

feanil commented Jun 7, 2024

@kdmccormick when you go to fix this, maybe just move this to JSON5 https://json5.org/ so that you can add comments. Renovate supports it.

@kdmccormick
Copy link
Member

Amazing, will do.

kdmccormick added a commit to kdmccormick/edx-platform that referenced this issue Jun 7, 2024
@kdmccormick
build: switch renovate.json to JSON5 for comment support
81f5a40 
Closes openedx#34940
@kdmccormick kdmccormick mentioned this issue Jun 7, 2024
Merged
kdmccormick added a commit that referenced this issue Jun 7, 2024
@kdmccormick
build: switch renovate.json to JSON5 for comment support (#34944)
c3d1586 
Allows us to use comments to explain why we pin (ignore) certain deps.

Renovate docs ref: https://docs.renovatebot.com/configuration-options/#configuration-options

Closes #34940
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kdmccormick kdmccormick

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: switch renovate.json to JSON5 for comment support kdmccormick/edx-platform
3 participants
@deborahgu @feanil @kdmccormick