Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: temporarily prevent renovate from updating this package #34938

Conversation

deborahgu
Copy link
Member

Minor (and therefore presumed-safe by renovate) version updates caused an exception on some deprecated code. Marking this package as not-safe for renovate until that code is removed, which will happen quite soon. see external (2U) ticket REV-4067 for details. cc @julianajlk

FIXES: APER-3502

Description

Describe what this pull request changes, and why. Include implications for people using this change.
Design decisions and their rationales should be documented in the repo (docstring / ADR), per
OEP-19, and can be
linked here.

Useful information to include:

  • Which edX user roles will this change impact? Common user roles are "Learner", "Course Author",
    "Developer", and "Operator".
  • Include screenshots for changes to the UI (ideally, both "before" and "after" screenshots, if applicable).
  • Provide links to the description of corresponding configuration changes. Remember to correctly annotate these
    changes.

Supporting information

Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.

Testing instructions

Please provide detailed step-by-step instructions for testing this change.

Deadline

"None" if there's no rush, or provide a specific date or event (and reason) if there is one.

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.
  • If your database migration can't be rolled back easily.

Minor (and therefore presumed-safe by renovate) version updates caused
an exception on some deprecated code. Marking this package as not-safe
for renovate until that code is removed, which  will happen quite soon.
see external (2U) ticket REV-4067 for details. cc @julianajlk

FIXES: APER-3502
@dianakhuang
Copy link
Contributor

PR to revert out this renovate change, with some more context on what broke: #34928

Copy link
Contributor

@julianajlk julianajlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

attempting to add a comment explaining the ignored dependency

Co-authored-by: Kyle McCormick <[email protected]>
@deborahgu deborahgu merged commit b937fd4 into master Jun 6, 2024
45 checks passed
@deborahgu deborahgu deleted the dkaplan1/APER-3502_enrolled-programs-detail-page-isnt-loading-on-web-and-mobile-apps branch June 6, 2024 20:36
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants