-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace builtin block Sass with vanilla CSS #35300
Comments
Perhaps duplicate of #35306 |
@farhan I've filled this one in. Let me know if you have any questions. |
This was referenced Sep 19, 2024
I have created following main epic story for per block conversion of sass to css After shifting of all the blocks from sass to css we can pick this story and do the left over cleaning. cc: @kdmccormick |
16 tasks
This was referenced Oct 24, 2024
This was referenced Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Background
Follows up from:
The goal of this task is to entirely convert the Sass in the ./xmodule/ directory into vanilla CSS which can be loaded with the standard ResourceLoader class from xblock.utils. The immediate benefit is that we can remove the xmodule Sass build steps from edx-platform. The longer-term benefit is that this will remove any Sass build concerns from the xblock extraction effort.
Tasks
npm run compile-sass-dev
).lms/static/css/*Display.css
andlms/static/css/*Editor.css
) into xmodule/assets. Add those CSS files to version control.add_sass_to_fragment
call with standard usage of axblock.utils.resources.ResourceLoader
andfragment.add_css
.add_sass_to_fragment
from xmodule.util.builtin_assets.py.scss
files under xmodule/assetscompile_sass_dir(...)
calls in scripts/compile_sass.sh which compile Sass under xmodule/assets.xmodule/assets/README.rst
The text was updated successfully, but these errors were encountered: