-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace builtin block Sass with vanilla CSS #35300
Comments
Perhaps duplicate of #35306 |
@farhan I've filled this one in. Let me know if you have any questions. |
I have created following main epic story for per block conversion of sass to css After shifting of all the blocks from sass to css we can pick this story and do the left over cleaning. cc: @kdmccormick |
Hey @farhan , could you or someone on your team:
.xmodule_display.xmodule_VideoBlock {
/* stylelint-disable-line */
/* stylelint-disable-line */
/* stylelint-disable-line */
/* stylelint-disable-line */
/* stylelint-disable-line */
/* stylelint-disable-line */
} |
Finally, before extracting the CSS to the xblock-contrib repo, I'd like to take care of this task: #32617 Let me know if that's something your team has time to take on soon. If not, I can take care of it. |
Background
Follows up from:
The goal of this task is to entirely convert the Sass in the ./xmodule/ directory into vanilla CSS which can be loaded with the standard ResourceLoader class from xblock.utils. The immediate benefit is that we can remove the xmodule Sass build steps from edx-platform. The longer-term benefit is that this will remove any Sass build concerns from the xblock extraction effort.
Tasks
npm run compile-sass-dev
).lms/static/css/*Display.css
andlms/static/css/*Editor.css
) into xmodule/assets. Add those CSS files to version control.add_sass_to_fragment
call with standard usage of axblock.utils.resources.ResourceLoader
andfragment.add_css
.add_sass_to_fragment
from xmodule.util.builtin_assets.py.scss
files under xmodule/assetscompile_sass_dir(...)
calls in scripts/compile_sass.sh which compile Sass under xmodule/assets.xmodule/assets/README.rst
The text was updated successfully, but these errors were encountered: