feat! Dropping Sass support from builtin video block #35506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farhan
force-pushed
the
farhan/sass-to-css-video-block
branch
from
15e37bf
to
364b0a9
Compare
farhan
force-pushed
the
farhan/sass-to-css-video-block
branch
from
364b0a9
to
9e119c4
Compare
farhan
force-pushed
the
farhan/sass-to-css-video-block
branch
from
bd41dcd
to
a509763
Compare
farhan
changed the title
farhan
commented
Sep 23, 2024
| if not css_absolute_path.is_file(): | ||
| raise FileNotFoundError(f"css file not found: {css_absolute_path}") | ||
| # fragment.add_css_url(str(css_absolute_path)) | ||
| fragment.add_css(css_absolute_path.read_text(encoding='utf-8')) |
There was a problem hiding this comment.
@kdmccormick I have changed css url addition to css content addition as css url is not accessible on browser and css file needs to add in the static files.
Please guide what should be the way forward of implementation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropping Sass support from builtin video block
Tickets:
#35300
#35306
Linked PRs:
https://github.com/openedx/edx-platform/pull/35434/files