Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a minimal yaml file for use with production.py #31366

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

feanil
Copy link
Contributor

@feanil feanil commented Nov 29, 2022

Sometimes you just want to run a few paver or django commands without
having to bring up the entire development stack.

This was super useful when we wanted to run some translations related workflows for the olive release.

@feanil feanil force-pushed the feanil/minimal_config branch 2 times, most recently from 495c6e0 to 484883a Compare November 29, 2022 17:10
Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I tested with:

pip install -r requirements/edx/development.txt -e .
LMS_CFG="$(pwd)/lms/envs/minimal.yml" ./manage.py lms shell

which brought me to a (seemingly) working LMS shell.

LGTM pending one request.

# This is the minimal settings you need to set to be able to get django to
# load when using the production.py settings files. It's useful to point
# LMS_CFG and CMS_CFG to this file to be able to run various paver commands
# without needing a full docker setup.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you link a followup ticket here, like this one? I feel better about checking in experimental code when I know it'll be easy for someone in the future to check up on whether the code can be either polished or removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# without needing a full docker setup.
---

SECRET_KEY: aseuothsaeotuhaseotisaotenihsaoetih
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is clearly a Dvorak keymash. I think we should keep that kind of pretension out of the codebase.

Sometimes you just want to run a few paver or django commands without
having to bring up the entire development stack.
Copy link
Contributor

@Carlos-Muniz Carlos-Muniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Groovy!
Looking forward to seeing this type of experimental feature added to other repositories as well.

@feanil feanil merged commit 5bb84e9 into master Nov 29, 2022
@feanil feanil deleted the feanil/minimal_config branch November 29, 2022 20:19
@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants