-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add a minimal yaml file for use with production.py #31366
Conversation
495c6e0
to
484883a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! I tested with:
pip install -r requirements/edx/development.txt -e .
LMS_CFG="$(pwd)/lms/envs/minimal.yml" ./manage.py lms shell
which brought me to a (seemingly) working LMS shell.
LGTM pending one request.
# This is the minimal settings you need to set to be able to get django to | ||
# load when using the production.py settings files. It's useful to point | ||
# LMS_CFG and CMS_CFG to this file to be able to run various paver commands | ||
# without needing a full docker setup. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you link a followup ticket here, like this one? I feel better about checking in experimental code when I know it'll be easy for someone in the future to check up on whether the code can be either polished or removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I linked to the same ticket for now(https://github.com/openedx/wg-developer-experience/issues/136).
# without needing a full docker setup. | ||
--- | ||
|
||
SECRET_KEY: aseuothsaeotuhaseotisaotenihsaoetih |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is clearly a Dvorak keymash. I think we should keep that kind of pretension out of the codebase.
Sometimes you just want to run a few paver or django commands without having to bring up the entire development stack.
484883a
to
f838652
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Groovy!
Looking forward to seeing this type of experimental feature added to other repositories as well.
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
EdX Release Notice: This PR has been deployed to the production environment. |
Sometimes you just want to run a few paver or django commands without
having to bring up the entire development stack.
This was super useful when we wanted to run some translations related workflows for the olive release.