-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Update from boto to boto3 storage backend. #31759
Conversation
Last attempt gave an error on prod. How to reproduce error Faced errors on
Boto3 PR #31282 which caused this issue. With boto encoding is also happening down the stream but in boto3 need to do this explicitly |
@@ -27,5 +27,5 @@ def export_course_metadata_task(self, course_key_string): # pylint: disable=unu | |||
""" | |||
course_key = CourseKey.from_string(course_key_string) | |||
highlights = get_all_course_highlights(course_key) | |||
highlights_content = ContentFile(json.dumps({'highlights': highlights})) | |||
highlights_content = ContentFile(json.dumps({'highlights': highlights}).encode('utf-8')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, this is apparently an open bug in django-storages with a PR to fix it that's been sitting around unmerged for almost 3 years for no particularly good reason: jschneier/django-storages#911
This reverts commit 31002ab.
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
EdX Release Notice: This PR has been deployed to the production environment. |
Update from boto to boto3 storage backend.
It will come under multiple prs to avoid huge change set.
For details review this issue
This PR will make change in
USER_TASKS_ARTIFACT_STORAGE
COURSE_IMPORT_EXPORT_STORAGE
COURSE_METADATA_EXPORT_STORAGE
Sandbox internal PR