Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove Jenkins CI scripts #31812

Merged
merged 1 commit into from
Feb 22, 2023
Merged

refactor!: remove Jenkins CI scripts #31812

merged 1 commit into from
Feb 22, 2023

Conversation

kdmccormick
Copy link
Member

@kdmccormick kdmccormick commented Feb 22, 2023

Description

These files were used to run tests on
build.testeng.edx.org, a Jenkins server.

All tests have sinced been moved over to
GitHub Actions, and build.testeng.edx.org
is decommissioned.

Other information

This helps with:

by reducing the number of shell scripts I need get passing ShellCheck.

Question for reviewers

I deleted:

  • scripts/jenkins-*.sh : definitely Jenkins-specific
  • scripts/Jenkinsfiles/* : definitely Jenkins-specific
  • scripts/xdist/* : I think these are Jenkins-specific, but could someone with knowledge about edx-platform CI confirm this?

These files were used to run tests on
build.testeng.edx.org, a Jenkins server.

All tests have sinced been moved over to
GitHub Actions, and build.testeng.edx.org
is decomissioned.
@kdmccormick kdmccormick changed the title build!: remove Jenkins CI scripts refactor!: remove Jenkins CI scripts Feb 22, 2023
Copy link
Contributor

@jmbowman jmbowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pytest-xdist in general is still useful for local test runs in order to take advantage of all available CPU cores, but the scripts here were specifically for running tests on multiple remote machines. You could use them to trigger a test run locally and farm them out across EC2 workers (and we verified that this works), but I'm pretty sure nobody outside the former Tools team ever did that; the primary use case was reducing the overall duration of test runs on Jenkins.

@kdmccormick
Copy link
Member Author

Sounds good, thanks for the review and that context.

@kdmccormick kdmccormick merged commit f3b658d into openedx:master Feb 22, 2023
@kdmccormick kdmccormick deleted the kdmccormick/rm-jenkins-script branch February 22, 2023 14:14
@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants