Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: build: copy from node_modules using NPM postinstall hook, not Paver #32766

Merged
merged 1 commit into from
Jul 17, 2023
Merged

revert: build: copy from node_modules using NPM postinstall hook, not Paver #32766

merged 1 commit into from
Jul 17, 2023
+107 −105

Conversation

kdmccormick
Copy link
Member

@kdmccormick kdmccormick commented Jul 17, 2023 •
edited
Loading

Reverts #32717 since it is breaking the Docker build,
both in the edx-platform CI, and for Tutor Nightly.

[email protected] postinstall
scripts/copy-node-modules.sh

sh: 1: scripts/copy-node-modules.sh: not found

The problems seems to be that npm install is run before scripts/
is copied in, but the new post-install hook counts on
scripts/copy-node-modules.sh existing.

@kdmccormick kdmccormick enabled auto-merge (squash) July 17, 2023 18:12
@kdmccormick kdmccormick enabled auto-merge (squash) July 17, 2023 18:13
@kdmccormick kdmccormick merged commit 5060ec5 into master Jul 17, 2023
42 checks passed
@kdmccormick kdmccormick deleted the revert-32717-kdmccormick/copy-node-modules branch July 17, 2023 18:34
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@kdmccormick kdmccormick mentioned this pull request Jul 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-smith-tcril brian-smith-tcril brian-smith-tcril approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kdmccormick @edx-pipeline-bot @brian-smith-tcril