Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support for newer npm and macOS #33232

Closed
wants to merge 1 commit into from
Closed

fix: support for newer npm and macOS #33232

wants to merge 1 commit into from

Conversation

mohd-akram
Copy link
Contributor

Description

macOS does not support the --force flag in cp, so use the equivalent -f flag instead. Newer versions of npm also require legacy-peer-deps to be set to true to install successfully. They also no longer have the npm bin command, so use npm root instead.

Testing instructions

Tested with paver update_assets.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 12, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @mohd-akram! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211
Copy link

Hi @openedx/arch-bom! Is this something you could help review/merge for us?

@mphilbrick211 mphilbrick211 requested a review from a team September 13, 2023 00:14
@robrap
Copy link
Contributor

robrap commented Sep 13, 2023

@mphilbrick211: @kdmccormick did so much work in this area, I wonder if he’d mind taking this on?

@mphilbrick211
Copy link

@mphilbrick211: @kdmccormick did so much work in this area, I wonder if he’d mind taking this on?

@kdmccormick - let us know if you would be ok reviewing/merging this. Thanks!

kdmccormick
kdmccormick requested changes Sep 14, 2023
View reviewed changes
Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, I can take this on @mphilbrick211

Thanks for the PR @mohd-akram , looking good! Just one change request.

We are currently transitioning from paver update_assets to npm run build (details, if you care), so could you test this with npm run build as well?

package.json Show resolved Hide resolved
@kdmccormick kdmccormick self-assigned this Sep 14, 2023
@mohd-akram @gabor-boros
fix: support for newer npm and macOS
d7b463f 
macOS does not support the `--force` flag in `cp`, so use the equivalent `-f`
flag instead. Newer versions of npm also require `legacy-peer-deps` to be set
to true to install successfully. They also no longer have the `npm bin`
command, so use `npm root` instead.
@mohd-akram mohd-akram closed this Oct 16, 2023
@openedx-webhooks
Copy link

@mohd-akram Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@kdmccormick kdmccormick mentioned this pull request Oct 16, 2023
Draft
@kdmccormick
Copy link
Member

Hey Mohamed, I like your proposed change, so I reopened an updated version of your PR over here: #33506

@mohd-akram
Copy link
Contributor Author

Sure thing, thanks for picking it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdmccormick kdmccormick kdmccormick requested changes

Assignees

@kdmccormick kdmccormick

Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mohd-akram @openedx-webhooks @mphilbrick211 @robrap @kdmccormick