-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bringing Master in to Theseus #33285
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the Course Card Image is absent on FB post after sharing by user.
enterprise version bump Commit generated by workflow `openedx/edx-platform/.github/workflows/upgrade-one-python-dependency.yml@refs/heads/master`
…nterprise-878e720 feat: Upgrade Python dependency edx-enterprise
The .dockerignore file smartly excludes lms/static/css from the Docker build, as most of its contents are generated CSS. However, there is one version-controlled subdirectory of lms/static/css: lms/static/css/vendor. In order to correctly build a Docker image using a bind-mounted edx-platform repository, we need this vendor directory to be included.
…33107) Bumps [aws-actions/configure-aws-credentials](https://github.com/aws-actions/configure-aws-credentials) from 1 to 3. - [Release notes](https://github.com/aws-actions/configure-aws-credentials/releases) - [Changelog](https://github.com/aws-actions/configure-aws-credentials/blob/main/CHANGELOG.md) - [Commits](aws-actions/configure-aws-credentials@v1...v3) --- updated-dependencies: - dependency-name: aws-actions/configure-aws-credentials dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit 3025ab5)
Minor updates around forgiving JWTs. Commit generated by workflow `openedx/edx-platform/.github/workflows/upgrade-one-python-dependency.yml@refs/heads/master`
…ons-26d8c21 feat: Upgrade Python dependency edx-drf-extensions
There exists a Sass file for lti_block's display, but not for its editor. However, during the `add_sass_to_fragment` refactoring, I mixed that up: I added a non-existent scss file to the studio_view but didn't add the actual scss file to the student_view. Course authors using the (deprecated) lti_block saw: We're having trouble rendering your component Students will not be able to access this component. Re-edit your component to fix the error. Error: Sass not found: /edx/app/edxapp/edx-platform/xmodule/assets/LTIBlockEditor.scss as a result of this bug. Original PR: #32592 Private-ref: https://2u-internal.atlassian.net/browse/TNL-11029
Uses the updated styles for the notification based on the new designs. Includes a button to open view the files directly in the notification. This also fix a bug where the notification was not appearing when paste a whole Unit.
chore: version bump
Co-authored-by: Muhammad Umar Khan <[email protected]>
Upgrade to use the `--combine-po-files` parameter in future ope-58 work.
Co-authored-by: connorhaugh <[email protected]>
The text plugin for requirejs is used to load text assets such as .underscore files. To avoid CORS issues when loading such assets from a different domain, such as a when a CDN is in use, this plugin loads such assets as .js files by adding a script tag. What this means in practice is that if you configure the platform to serve static assets from a CDN, it will try to load `file.underscore.js` instead of `file.underscore`. We can override this behaviour by providing a `useXhr` function for the text plugin configuration. The plugin will use this function to determine whether to use XHR or the script tag approach. In this change we are asking it to always use XHR since the concerns about CORS raised by the plugins documentation don't apply here. ref: https://github.com/requirejs/text/blob/3f9d4c19b3a1a3c6f35650c5788cbea1db93197a/README.md#xhr-restrictions
…3271) Sometimes this make target doubles or even triples the comment. I think this is due to a temporary failure in the wget call, which is then ignored and an additional comment is added onto the top. If this happens multiple times in a row, you get multiple additions. Removing the `|| touch` should fix this, and surface any errors that are happening.
…33126) Adds a GH workflow that will run `make compile-requirements` and create a PR for it and overhauls the requirements README with info on how to use the new workflows. README changes: - Group the workflow/makefile info under a new heading - Switch to imperative for headings - Move "Upgrade all dependencies" to end of list (uncommon for people to actually need this command, I suspect) - Add "Add a dependency" - Preamble about .in and .txt files and Mac vs. Linux, as well as about forks Also, some style fixes to upgrade-one-python-dependency GH workflow: - Fix indentation in inputs block - Remove "-workflow" from job name (probably copied from another workflow) - Wrap a long line
This should probably be turned into an ADR at some point, but for now I've just recreated the page on the public wiki. (The space it was in had been deleted during the 2U/Axim split.)
…ough cohorts (#33191) This does two major things: * Removes subsections from a student's course outline if the subsection's units are all restricted to a cohort that the student is not a part of (see CohortPartitionGroupsOutlineProcessor). * Removes sections from the course outline if the user is not allowed to see any of its child subsections.
enterprise version bump Commit generated by workflow `openedx/edx-platform/.github/workflows/upgrade-one-python-dependency.yml@refs/heads/master`
The documentation section, which now has an edx-platform specific doc link, was moved closer to the top of the README to make it stand out more.
…nterprise-3c3306c feat: Upgrade Python dependency edx-enterprise
pshiu
approved these changes
Sep 19, 2023
grmartin
changed the title
Bringing Master to Theseus
chore: bringing Master in to Theseus
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.