Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: export tagged content library as csv [FC-0049] #34246

Merged
merged 86 commits into from
Mar 4, 2024
Merged

feat: export tagged content library as csv [FC-0049] #34246

merged 86 commits into from
Mar 4, 2024

Conversation

rpenido
Copy link
Contributor

@rpenido rpenido commented Feb 15, 2024 •
edited
Loading

Description

This PR implements a feature to export a CSV with the library structure and its blocks, showing all tags applied to them.

More information

Part of:

Depends on:

Testing instructions

  1. Check the tests cover the implemented feature
  2. Follow the instructions from feat: add export library tags menu [FC-0049] openedx-unsupported/frontend-app-library-authoring#412 to test it from the MFE

Private-ref: FAL-3611

rpenido and others added 30 commits January 25, 2024 16:41
@rpenido
feat: export tagged course as csv
52bc665
@rpenido
docs: add comment
f275908
@rpenido
fix: add select_related to ObjectTag query
a870dfd
@rpenido
fix: always use objecttag.value
4dd027a
@rpenido
docs: change comment position
5fb03aa
@rpenido
refactor: rename serializer to a more sane name
8f1238e
@rpenido
refactor: remove download param
bdedf93
@rpenido
refactor: create a new view to export objecttags
04ca072
@rpenido
Merge branch 'master' into rpenido/fal-3610-download-course-tag-sprea…
a8a6e7e 
…dsheet
@rpenido
refactor: change api and view structure
b01d6d4
@rpenido
Merge branch 'master' into rpenido/fal-3610-download-course-tag-sprea…
0871537 
…dsheet
@rpenido
docs: remove old comment
18a8425
@rpenido
docs: revert view docstring
38ae353
@rpenido
fix: remove include_children query param
b65a6c8
@rpenido
fix: removing .all() call from queryset
f5ac3a6
@rpenido
refactor: method rename
debf254
@rpenido
fix: filter deleted tags
9726d6d
@rpenido
fix: pylint
c8c12bb
@rpenido
fix: quote string in csv export
1f11b17
@rpenido
test: add querycount
484c042
@rpenido
fix: pylint
6b6ba34
@rpenido
fix: pylint..
9096454
@rpenido
fix: pylint
a688689
@pomegranited
test: compare results to hardcoded strings
30e06d0 
instead of reproducing feature logic in the tests
@pomegranited
test: Adds "deleted" object tags to ensure they are omitted from results
35a3d2b
@pomegranited
test: adds untagged blocks with children
1e13f54 
ensures that untagged elements and their children are included in results
@rpenido
revert: undo removed property
e9335c8
@rpenido
style: fix camelCase
ab1a69e
@rpenido
refactor: remove xblock from TaggedContent and include_children param
db9116d
@rpenido
fix: remove UsageKey
9b3dee8
@rpenido
Copy link
Contributor Author

rpenido commented Feb 22, 2024

Hi @bradenmacdonald ! Could you do a CC review here?

@rpenido rpenido changed the title feat: export tagged content library as csv feat: export tagged content library as csv [FC-0049] Feb 22, 2024
bradenmacdonald
bradenmacdonald approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please improve this docstring and remove uwsgi.ini from the PR before I merge it though.

openedx/core/djangoapps/content_tagging/api.py Show resolved Hide resolved
@rpenido
Copy link
Contributor Author

rpenido commented Feb 23, 2024

I think this was affected by 86f1e5e
I will check and fix it.

@rpenido rpenido marked this pull request as draft February 23, 2024 13:53
@rpenido
Copy link
Contributor Author

rpenido commented Feb 23, 2024 •
edited
Loading

uwsgi.ini

@bradenmacdonald Do you think it is ok to put this in .gitignore? This file is generated by Tutor when I have the edx-platform mounted.

@bradenmacdonald
Copy link
Contributor

@rpenido Maybe not for now - see #32268 and overhangio/tutor#846 for how Regis wants to fix it.

@bradenmacdonald
Copy link
Contributor

I think this was affected by 86f1e5e
I will check and fix it.

OK, thanks. Let me know when ready.

@rpenido
Copy link
Contributor Author

rpenido commented Feb 28, 2024

OK, thanks. Let me know when ready.

Hi @bradenmacdonald! This is ready for a CC review.

@rpenido rpenido marked this pull request as ready for review March 4, 2024 11:50
@rpenido
Copy link
Contributor Author

rpenido commented Mar 4, 2024

Hi @bradenmacdonald ! If you have some time, could you take a look at this?
Thank you!

@bradenmacdonald bradenmacdonald merged commit 42418fb into openedx:master Mar 4, 2024
47 checks passed
@bradenmacdonald bradenmacdonald deleted the rpenido/fal-3611-download-library-tag-spreadsheet branch March 4, 2024 19:35
@openedx-webhooks
Copy link

@rpenido 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@bradenmacdonald
Copy link
Contributor

@rpenido Sorry for the delay!

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pomegranited pomegranited pomegranited approved these changes

@bradenmacdonald bradenmacdonald bradenmacdonald approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rpenido @openedx-webhooks @bradenmacdonald @edx-pipeline-bot @pomegranited