-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paver Removal 1/3 #34829
Paver Removal 1/3 #34829
Conversation
f8f755e
to
072f50d
Compare
This is the first step of Paver removal. These are the parts that we are confident are unused. Part of: openedx#34467
They haven't been run in CI in years, and had gradually become broken
We haven't unit-tested or linted these modules ever since testing was moved from Jenkins to GitHub Actions.
072f50d
to
1a2d118
Compare
echo "Finding fixme's and storing report..." | ||
run_paver_quality find_fixme || { EXIT=1; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This step doesn't do anything because there is no pylint report to read the fixme's from. It has been like this ever since pylint was moved into its own github action, ~2021.
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
Description:
pavelib/docs.py:*
pavelib/i18n.py:*
pavelib/servers.py:*
pavelib/quality.py:run_quality
pavelib/quality.py:run_pylint
pavelib/quality.py:find_fixme
Part of:
Next PRs:
Testing instructions: None
Merge considerations: None, this is can go out whenever
Other information: I'm intentionally omitting doc updates. We'll do that all at once in Step 3.