-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrading simple api to drf compatible ( 3rd api ) list_email_content #35111
Conversation
ae35283
to
4781036
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to be merged.
@feanil Please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great and I tested that the API works.
@@ -2165,23 +2165,35 @@ def list_background_email_tasks(request, course_id): | |||
return JsonResponse(response_payload) | |||
|
|||
|
|||
@require_POST |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's confusing that this is a POST request in the first place given that it is not sending any data in the POST body and not making any modifications. But that change was made in #12719 for reasons that are unclear to us now so we'll leave it as is for now and we can re-visit if/when we want to revamp the instructor APIs further.
This will at-least make these APIs all visible in our openapi spec and make the APIs usable by other token types than just session.
(Not something you need to do anything about, just leaving a not for future investigators.)
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
…ontent (openedx#35111) * feat: upgrading simple api to drf compatible.
Issue: #35112
existing API Code
Updating api code using DRF.
Steps to verify on local tutor instance:
1: Open admin panel and laod this page and enable both checkboxes and save.
2: Open this page and enter
course id
andenabled email
.3. Open instructor dashboard.
4.
email
tab is visible and click on that and further clicknew experience
.5. Send an email email now.
6. Click on
Email Task History
now it will hit the related API.Steps to verify via postman.
expected result