Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add waffle flag for First Purchase Discount override #35133

Merged
merged 3 commits into from
Jul 19, 2024

Conversation

julianajlk
Copy link
Contributor

@julianajlk julianajlk commented Jul 17, 2024

REV-4097.

The OC New Registrant Promo Update involves overriding the First Purchase Discount from EDXWELCOME/BIENVENIDOAEDX at 15% discount to a new code with 30% discount.

This is where the learning MFE gets the metadata for a course and user to decide whether to display the FPD code or not in the Upgrade Notification in Course Home and Courseware experience.

We want to be able to easily rollback from one coupon code to the other if necessary, which is why we are using a waffle flag.

@julianajlk julianajlk force-pushed the julianajlk/REV-4097/fpd-edxwelcome-override branch 2 times, most recently from 9c94269 to 75ab69f Compare July 17, 2024 21:59
Copy link
Contributor

@christopappas christopappas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a few thoughts. what do you think?

openedx/features/discounts/applicability.py Outdated Show resolved Hide resolved
openedx/features/discounts/applicability.py Outdated Show resolved Hide resolved
openedx/features/discounts/applicability.py Outdated Show resolved Hide resolved
@julianajlk julianajlk force-pushed the julianajlk/REV-4097/fpd-edxwelcome-override branch from b131421 to d3cc4f2 Compare July 18, 2024 20:38
@julianajlk julianajlk force-pushed the julianajlk/REV-4097/fpd-edxwelcome-override branch from 61493dd to 2f8fad6 Compare July 19, 2024 12:31
@julianajlk julianajlk merged commit 475b49c into master Jul 19, 2024
49 checks passed
@julianajlk julianajlk deleted the julianajlk/REV-4097/fpd-edxwelcome-override branch July 19, 2024 12:59
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

mudassir-hafeez pushed a commit to mudassir-hafeez/edx-platform that referenced this pull request Jul 24, 2024
mudassir-hafeez pushed a commit to mudassir-hafeez/edx-platform that referenced this pull request Jul 24, 2024
mudassir-hafeez pushed a commit to mudassir-hafeez/edx-platform that referenced this pull request Jul 24, 2024
mudassir-hafeez pushed a commit to mudassir-hafeez/edx-platform that referenced this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants